Issue 5143 - Convert ElemHideEmulation to C++

compiled/ElemHideEmulation.h

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 #pragma once
 
 #include <vector>
 
 #include "bindings/runtime.h"
 #include "intrusive_ptr.h"
 #include "filter/ElemHideBase.h"
+
+class ElemHide;
 
 class ElemHideEmulation_FilterList : public ref_counted
 {
   std::vector<ElemHideBasePtr> mFilters;
 public:
   size_t BINDINGS_EXPORTED GetFilterCount() const
   {
     return mFilters.size();
   }
 
@@ skipping 10 matching lines @@
   {
     mFilters.push_back(filter);
   }
 
 };
 
 class ElemHideEmulation : public ref_counted
 {
   StringMap<ElemHideBasePtr> mFilters;
 
-  static ElemHideEmulation* mInstance;

[sergei, 2018/01/25 16:04:01]

Could you please turn it into non-singleton?

[hub, 2018/01/25 19:05:27]

Ah yes, I was meaning to the same as for ElemHide. Definitely.

-
 public:
-  static ElemHideEmulation* BINDINGS_EXPORTED GetInstance()
+  static ElemHideEmulation* BINDINGS_EXPORTED Create()
   {
-    return mInstance;
+    return new ElemHideEmulation();
   }
 
   void BINDINGS_EXPORTED Add(ElemHideBase&);
   void BINDINGS_EXPORTED Remove(ElemHideBase&);
   void BINDINGS_EXPORTED Clear();
-  ElemHideEmulation_FilterList* BINDINGS_EXPORTED GetRulesForDomain(DependentString&);
+  ElemHideEmulation_FilterList* BINDINGS_EXPORTED GetRulesForDomain(const ElemHide&, DependentString&);
 };