Issue 5143 - Convert ElemHideEmulation to C++

compiled/ElemHideEmulation.cpp

Index: compiled/ElemHideEmulation.cpp
===================================================================
new file mode 100644
--- /dev/null
+++ b/compiled/ElemHideEmulation.cpp
@@ -0,0 +1,51 @@
+/*
+ * This file is part of Adblock Plus <https://adblockplus.org/>,
+ * Copyright (C) 2006-present eyeo GmbH
+ *
+ * Adblock Plus is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 3 as
+ * published by the Free Software Foundation.
+ *
+ * Adblock Plus is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#include "ElemHide.h"
+#include "ElemHideEmulation.h"
+
+ElemHideEmulation* ElemHideEmulation::mInstance = new ElemHideEmulation();
+
+void ElemHideEmulation::Add(ElemHideBase& filter)
+{
+  mFilters[filter.GetText()] = ElemHideBasePtr(&filter);
+}
+
+void ElemHideEmulation::Remove(ElemHideBase& filter)
+{
+  mFilters.erase(filter.GetText());
+}
+
+void ElemHideEmulation::Clear()
+{
+  mFilters.clear();
+}
+
+ElemHideEmulation_FilterList* ElemHideEmulation::GetRulesForDomain(const ElemHide& elemHide, DependentString& domain)
+{
+  intrusive_ptr<ElemHideEmulation_FilterList> result(new ElemHideEmulation_FilterList());
+  for (const auto& entry: mFilters)
+  {
+    DependentString docDomain(domain);
+    if (!entry.is_deleted() &&

[sergei, 2018/01/30 16:00:47]

Well, because of https://issues.adblockplus.org/ticket/6280 we should actually
check that the entry is not invalid.

[hub, 2018/01/30 17:37:58]

Done.

[hub, 2018/01/30 17:53:29]

I forgot to add that actually we won't get invalid entries as the iterator
exclude them. Even though I did change the code.

[sergei, 2018/01/30 17:55:31]

The very first entry can be invalid :)

+        entry.second->IsActiveOnDomain(docDomain) &&
+        !elemHide.GetException(*entry.second, domain))
+      result->push_back(entry.second);
+  }
+
+  return result.release();
+}