compiled/filter/ActiveFilter.h - Issue 29595633: Issue 5870 - Implement the new ElemHideEmulation filter type

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: compiled/filter/ActiveFilter.h

Issue 29595633: Issue 5870 - Implement the new ElemHideEmulation filter type (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/

Patch Set: Review comments Created Jan. 30, 2018, 10:52 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | compiled/filter/ActiveFilter.cpp » ('j') | test/compiled/Filter.cpp » ('J')

OLD	NEW
1 /*	1 /*

2 * This file is part of Adblock Plus <https://adblockplus.org/>,	2 * This file is part of Adblock Plus <https://adblockplus.org/>,

3 * Copyright (C) 2006-present eyeo GmbH	3 * Copyright (C) 2006-present eyeo GmbH

4 *	4 *

5 * Adblock Plus is free software: you can redistribute it and/or modify	5 * Adblock Plus is free software: you can redistribute it and/or modify

6 * it under the terms of the GNU General Public License version 3 as	6 * it under the terms of the GNU General Public License version 3 as

7 * published by the Free Software Foundation.	7 * published by the Free Software Foundation.

8 *	8 *

9 * Adblock Plus is distributed in the hope that it will be useful,	9 * Adblock Plus is distributed in the hope that it will be useful,

10 * but WITHOUT ANY WARRANTY; without even the implied warranty of	10 * but WITHOUT ANY WARRANTY; without even the implied warranty of

(...skipping 42 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
53 void ParseDomains(const String& domains, String::value_type separator) const;	53 void ParseDomains(const String& domains, String::value_type separator) const;

54 void AddSitekey(const String& sitekey) const;	54 void AddSitekey(const String& sitekey) const;

55 virtual SitekeySet* GetSitekeys() const;	55 virtual SitekeySet* GetSitekeys() const;

56 mutable std::unique_ptr<DomainMap> mDomains;	56 mutable std::unique_ptr<DomainMap> mDomains;

57 mutable std::unique_ptr<SitekeySet> mSitekeys;	57 mutable std::unique_ptr<SitekeySet> mSitekeys;

58 private:	58 private:

59 bool mIgnoreTrailingDot;	59 bool mIgnoreTrailingDot;

60 public:	60 public:

61 static constexpr Type classType = Type::ACTIVE;	61 static constexpr Type classType = Type::ACTIVE;

62 explicit ActiveFilter(Type type, const String& text, bool ignoreTrailingDot);	62 explicit ActiveFilter(Type type, const String& text, bool ignoreTrailingDot);

	63 explicit ActiveFilter(Type type, String&& text, bool ignoreTrailingDot);

63 FILTER_PROPERTY(bool, mDisabled, FILTER_DISABLED, GetDisabled, SetDisabled);	64 FILTER_PROPERTY(bool, mDisabled, FILTER_DISABLED, GetDisabled, SetDisabled);

64 FILTER_PROPERTY(unsigned int, mHitCount, FILTER_HITCOUNT,	65 FILTER_PROPERTY(unsigned int, mHitCount, FILTER_HITCOUNT,

65 GetHitCount, SetHitCount);	66 GetHitCount, SetHitCount);

66 FILTER_PROPERTY(unsigned int, mLastHit, FILTER_LASTHIT,	67 FILTER_PROPERTY(unsigned int, mLastHit, FILTER_LASTHIT,

67 GetLastHit, SetLastHit);	68 GetLastHit, SetLastHit);

68 bool BINDINGS_EXPORTED IsActiveOnDomain(DependentString& docDomain,	69 bool BINDINGS_EXPORTED IsActiveOnDomain(DependentString& docDomain,

69 const String& sitekey = DependentString()) const;	70 const String& sitekey = DependentString()) const;

70 bool BINDINGS_EXPORTED IsActiveOnlyOnDomain(DependentString& docDomain) const;	71 bool BINDINGS_EXPORTED IsActiveOnlyOnDomain(DependentString& docDomain) const;

71 bool BINDINGS_EXPORTED IsGeneric() const;	72 bool BINDINGS_EXPORTED IsGeneric() const;

72 OwnedString BINDINGS_EXPORTED Serialize() const;	73 OwnedString BINDINGS_EXPORTED Serialize() const;

73 };	74 };

74	75

75 typedef intrusive_ptr<ActiveFilter> ActiveFilterPtr;	76 typedef intrusive_ptr<ActiveFilter> ActiveFilterPtr;

OLD	NEW