compiled/filter/ElemHideBase.h - Issue 29595633: Issue 5870 - Implement the new ElemHideEmulation filter type

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: compiled/filter/ElemHideBase.h

Issue 29595633: Issue 5870 - Implement the new ElemHideEmulation filter type (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/

Left Patch Set: Rebased patch. Fix assertion. Created Nov. 27, 2017, 3:13 p.m.

Right Patch Set: Deal with ill formed filters. Created Feb. 14, 2018, 5:05 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Right: Side by side diff | Download

LEFT	RIGHT
(no file at all)
1 /*	1 /*

2 * This file is part of Adblock Plus <https://adblockplus.org/>,	2 * This file is part of Adblock Plus <https://adblockplus.org/>,

3 * Copyright (C) 2006-present eyeo GmbH	3 * Copyright (C) 2006-present eyeo GmbH

4 *	4 *

5 * Adblock Plus is free software: you can redistribute it and/or modify	5 * Adblock Plus is free software: you can redistribute it and/or modify

6 * it under the terms of the GNU General Public License version 3 as	6 * it under the terms of the GNU General Public License version 3 as

7 * published by the Free Software Foundation.	7 * published by the Free Software Foundation.

8 *	8 *

9 * Adblock Plus is distributed in the hope that it will be useful,	9 * Adblock Plus is distributed in the hope that it will be useful,

10 * but WITHOUT ANY WARRANTY; without even the implied warranty of	10 * but WITHOUT ANY WARRANTY; without even the implied warranty of

(...skipping 45 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
56 }	56 }

57 };	57 };

58	58

59 class ElemHideBase : public ActiveFilter	59 class ElemHideBase : public ActiveFilter

60 {	60 {

61 protected:	61 protected:

62 ElemHideData mData;	62 ElemHideData mData;

63 public:	63 public:

64 static constexpr Type classType = Type::ELEMHIDEBASE;	64 static constexpr Type classType = Type::ELEMHIDEBASE;

65 explicit ElemHideBase(Type type, const String& text, const ElemHideData& data) ;	65 explicit ElemHideBase(Type type, const String& text, const ElemHideData& data) ;

66 static Type Parse(DependentString& text, ElemHideData& data);	66 static Type Parse(DependentString& text, ElemHideData& data, bool& needConvers ion);

	67 static DependentString ConvertFilter(String& text, String::size_type& at);

67	68

68 OwnedString BINDINGS_EXPORTED GetSelector() const;	69 OwnedString BINDINGS_EXPORTED GetSelector() const;

69 OwnedString BINDINGS_EXPORTED GetSelectorDomain() const;	70 OwnedString BINDINGS_EXPORTED GetSelectorDomain() const;

70 };	71 };

71	72

72 typedef intrusive_ptr<ElemHideBase> ElemHideBasePtr;	73 typedef intrusive_ptr<ElemHideBase> ElemHideBasePtr;

73	74

74 ABP_NS_END	75 ABP_NS_END

LEFT	RIGHT