Issue 5870 - Implement the new ElemHideEmulation filter type

test/elemHideEmulation.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 69 matching lines @@
       test.equal(selectors.selectorAt(1), ".foo");
       test.equal(selectors.filterKeyAt(1), "example.com##.foo");
     })(elemHide.getSelectorsForDomain("example.com", 0));
 
     withNAD(0, filter3 =>
     {
       elemHide.add(filter3);
 
       withNAD(
         0, selectors =>
-          test.equal(selectors.selectorCount, 3))(
+        {
+          test.equal(selectors.selectorCount, 3);
+          test.equal(selectors.selectorAt(0), "#ads");
+          test.equal(selectors.selectorAt(1), ".message");
+          test.equal(selectors.selectorAt(2), ".foo");
+        })(
         elemHide.getSelectorsForDomain("example.com", 0));
 
       withNAD(
         0, selectors =>
-          test.equal(selectors.selectorCount, 3))(
+        {
+          test.equal(selectors.selectorCount, 3);
+          test.equal(selectors.selectorAt(0), "#ads");
+          test.equal(selectors.selectorAt(1), ".message");
+          test.equal(selectors.selectorAt(2), ".foo");
+        })(
         elemHide.getSelectorsForDomain("mail.example.com", 0));
 
       withNAD(0, filter4 =>
       {
         elemHide.add(filter4);
         withNAD(
           0, selectors =>
-            test.equal(selectors.selectorCount, 3))(
+          {
+            test.equal(selectors.selectorCount, 3);
+            test.equal(selectors.selectorAt(0), "#ads");
+            test.equal(selectors.selectorAt(1), ".message");
+            test.equal(selectors.selectorAt(2), ".foo");
+          })(
           elemHide.getSelectorsForDomain("example.com", 0));
 
         withNAD(
           0, selectors =>
-            test.equal(selectors.selectorCount, 2))(
+          {
+            test.equal(selectors.selectorCount, 2);
+            test.equal(selectors.selectorAt(0), "#ads");
+            test.equal(selectors.selectorAt(1), ".foo");
+          })(
           elemHide.getSelectorsForDomain("mail.example.com", 0));
 
         withNAD(
           0,
           unconditionals =>
-            test.equal(unconditionals.selectorCount, 1))(elemHide.getUnconditionalSelectors());
+          {
+            test.equal(unconditionals.selectorCount, 1);
+            test.equal(unconditionals.selectorAt(0), "#ads");
+          })(elemHide.getUnconditionalSelectors());
 
         elemHide.remove(filter4);
       })(Filter.fromText("mail.example.com#@#.message"));
 
       withNAD(
         0, selectors =>
-          test.equal(selectors.selectorCount, 3))(
-        elemHide.getSelectorsForDomain("example.com", 0));
+        {
+          test.equal(selectors.selectorCount, 3);
+          test.equal(selectors.selectorAt(0), "#ads");
+          test.equal(selectors.selectorAt(1), ".message");
+          test.equal(selectors.selectorAt(2), ".foo");
+        })(elemHide.getSelectorsForDomain("example.com", 0));
 
       withNAD(
         0, selectors =>
-          test.equal(selectors.selectorCount, 3))(
-        elemHide.getSelectorsForDomain("mail.example.com", 0));
+        {
+          test.equal(selectors.selectorCount, 3);
+          test.equal(selectors.selectorAt(0), "#ads");
+          test.equal(selectors.selectorAt(1), ".message");
+          test.equal(selectors.selectorAt(2), ".foo");
+        })(elemHide.getSelectorsForDomain("mail.example.com", 0));
 
       elemHide.remove(filter3);
     })(Filter.fromText("example.com##.message"));
 
     withNAD(
       0, selectors =>
         test.equal(selectors.selectorCount, 2))(
       elemHide.getSelectorsForDomain("example.com", 0));
   })(ElemHide.create());
 
   test.done();
 };
 
 exports.testSyntaxConversion = function(test)
 {
   function checkConvertedFilter(old, converted)
   {
-    let filter = Filter.fromText(old);

[sergei, 2018/01/30 19:02:40]

`filter` should be released.

[hub, 2018/01/30 22:53:13]

Done.

-
-    test.equal(filter.text, converted);
+    withNAD(
+      0, filter => test.equal(filter.text, converted))(Filter.fromText(old));
   }
 
-  checkConvertedFilter("example.com#?#foo[-abp-properties='something']bar", "example.com#?#foo:-abp-properties(something)bar");
+  checkConvertedFilter("example.com##foo[-abp-properties='something']bar", "example.com#?#foo:-abp-properties(something)bar");
   checkConvertedFilter("example.com#@#foo[-abp-properties='something']bar", "example.com#@#foo:-abp-properties(something)bar");
-  checkConvertedFilter("example.com#?#[-abp-properties=\"something\"]", "example.com#?#:-abp-properties(something)");
-  checkConvertedFilter("example.com#?#[-abp-properties=(something)]", "example.com#?#:-abp-properties((something))");
+  checkConvertedFilter("example.com##[-abp-properties=\"something\"]", "example.com#?#:-abp-properties(something)");
+  checkConvertedFilter("example.com##[-abp-properties='(something)']", "example.com#?#:-abp-properties((something))");
 
   test.done();
 };
 
 exports.testDomainRestrictions = function(test)
 {
   function testSelectorMatches(description, filters, domain, expectedMatches)
   {
     withNAD([0, 1], (elemHide, elemHideEmulation) =>
     {
@@ skipping 113 matching lines @@
         "www.example.com",
         []
       );
     })(Filter.fromText("example.com##filter1"),
        Filter.fromText("www.example.com##filter2"),
        Filter.fromText("other.example.com##filter3"));
   })(ElemHide.create(), ElemHideEmulation.create());
 
   test.done();
 };