Issue 5870 - Implement the new ElemHideEmulation filter type

test/compiled/Filter.cpp

+/*
+ * This file is part of Adblock Plus <https://adblockplus.org/>,
+ * Copyright (C) 2006-present eyeo GmbH
+ *
+ * Adblock Plus is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 3 as
+ * published by the Free Software Foundation.
+ *
+ * Adblock Plus is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
+ */
 

[hub, 2018/01/30 23:12:01]

I have an update with the license header I forgot.

-
-#include "gtest/gtest.h"
+#include <gtest/gtest.h>
 #include "compiled/String.h"
 #include "compiled/filter/Filter.h"
+#include "compiled/filter/ElemHideBase.h"
+
+ABP_NS_USING
 
 TEST(TestFilter, testFromText)
 {
-  OwnedString t(u"www.example.com#@#:-abp-properties(foo)"_str);
+  OwnedString t(u"www.example.com#?#:-abp-properties(foo)"_str);
   DependentString text(t);
 
-  FilterPtr filter(Filter::FromText(text));
+  FilterPtr filter(Filter::FromText(text), false);
+  EXPECT_EQ(filter->GetText(), u"www.example.com#?#:-abp-properties(foo)"_str);
+}
+
+TEST(TestFilter, testFilterConversionText)
+{
+  {
+    OwnedString t(u"www.example.com##[-abp-properties='foo']"_str);
+    DependentString text(t);
+
+    FilterPtr filter(Filter::FromText(text), false);
+    EXPECT_EQ(filter->GetText(), u"www.example.com#?#:-abp-properties(foo)"_str);
+  }
+  {
+    OwnedString t(u"example.com##foo[-abp-properties='something']bar"_str);
+    DependentString text(t);
+
+    FilterPtr filter(Filter::FromText(text), false);
+    EXPECT_EQ(filter->GetText(), u"example.com#?#foo:-abp-properties(something)bar"_str);
+  }
+  {
+    OwnedString t(u"foo.com##[-abp-properties='/margin: [3-4]{2}/']"_str);
+    DependentString text(t);
+
+    FilterPtr filter(Filter::FromText(text), false);
+    EXPECT_EQ(filter->GetText(), u"foo.com#?#:-abp-properties(/margin: [3-4]{2}/)"_str);
+    ASSERT_TRUE(filter->As<ElemHideBase>());
+    EXPECT_EQ(filter->As<ElemHideBase>()->GetSelector(), u":-abp-properties(/margin: [3-4]\\7B 2\\7D /)"_str);
+  }
+}
+
+TEST(TestFilter, testFilterExceptionConversionText)
+{
+  OwnedString t(u"www.example.com#@#[-abp-properties='foo']"_str);
+  DependentString text(t);
+
+  FilterPtr filter(Filter::FromText(text), false);
   EXPECT_EQ(filter->GetText(), u"www.example.com#@#:-abp-properties(foo)"_str);
 }

[hub, 2018/01/30 23:12:01]

and more comprehensive tests for this part. This was to test the constructor
chain.

+
+TEST(TestFilter, testFilterSyntaxErrorConversion)
+{
+  {
+    OwnedString t(u"www.example.com#@#[-abp-properties='foo'bar'baz']"_str);
+    DependentString text(t);
+
+    FilterPtr filter(Filter::FromText(text), false);
+    EXPECT_FALSE(filter);
+  }
+  {
+    OwnedString t(u"www.example.com#@#[-abp-properties='foo'bar']"_str);
+    DependentString text(t);
+
+    FilterPtr filter(Filter::FromText(text), false);
+    EXPECT_FALSE(filter);
+  }
+  {
+    OwnedString t(u"www.example.com#@#[-abp-properties='foo'bar]"_str);
+    DependentString text(t);
+
+    FilterPtr filter(Filter::FromText(text), false);
+    EXPECT_FALSE(filter);
+  }
+  {
+    OwnedString t(u"www.example.com#@#[-abp-properties=bar'foo']"_str);
+    DependentString text(t);
+
+    FilterPtr filter(Filter::FromText(text), false);
+    EXPECT_FALSE(filter);
+  }
+}