Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: compiled/filter/ElemHideBase.h

Issue 29595633: Issue 5870 - Implement the new ElemHideEmulation filter type (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/
Left Patch Set: Reworked the logic and added tests Created Jan. 31, 2018, 9:07 p.m.
Right Patch Set: Deal with ill formed filters. Created Feb. 14, 2018, 5:05 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details. 12 * GNU General Public License for more details.
13 * 13 *
14 * You should have received a copy of the GNU General Public License 14 * You should have received a copy of the GNU General Public License
15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. 15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
16 */ 16 */
17 17
18 #pragma once 18 #pragma once
19 19
20 #include <cstddef> 20 #include <cstddef>
21 21
22 #include "../base.h"
22 #include "ActiveFilter.h" 23 #include "ActiveFilter.h"
23 #include "../bindings/runtime.h" 24 #include "../bindings/runtime.h"
25
26 ABP_NS_BEGIN
24 27
25 struct ElemHideData 28 struct ElemHideData
26 { 29 {
27 String::size_type mDomainsEnd; 30 String::size_type mDomainsEnd;
28 String::size_type mSelectorStart; 31 String::size_type mSelectorStart;
29 bool mNeedConversion;
30 32
31 bool HasDomains() const 33 bool HasDomains() const
32 { 34 {
33 return mDomainsEnd != 0; 35 return mDomainsEnd != 0;
34 } 36 }
35 37
36 DependentString GetDomainsSource(String& text) const 38 DependentString GetDomainsSource(String& text) const
37 { 39 {
38 return DependentString(text, 0, mDomainsEnd); 40 return DependentString(text, 0, mDomainsEnd);
39 } 41 }
(...skipping 14 matching lines...) Expand all
54 } 56 }
55 }; 57 };
56 58
57 class ElemHideBase : public ActiveFilter 59 class ElemHideBase : public ActiveFilter
58 { 60 {
59 protected: 61 protected:
60 ElemHideData mData; 62 ElemHideData mData;
61 public: 63 public:
62 static constexpr Type classType = Type::ELEMHIDEBASE; 64 static constexpr Type classType = Type::ELEMHIDEBASE;
63 explicit ElemHideBase(Type type, const String& text, const ElemHideData& data) ; 65 explicit ElemHideBase(Type type, const String& text, const ElemHideData& data) ;
64 static Type Parse(DependentString& text, ElemHideData& data); 66 static Type Parse(DependentString& text, ElemHideData& data, bool& needConvers ion);
65 static OwnedString ConvertFilter(const String& text, String::size_type& at); 67 static DependentString ConvertFilter(String& text, String::size_type& at);
66 68
67 OwnedString BINDINGS_EXPORTED GetSelector() const; 69 OwnedString BINDINGS_EXPORTED GetSelector() const;
68 OwnedString BINDINGS_EXPORTED GetSelectorDomain() const; 70 OwnedString BINDINGS_EXPORTED GetSelectorDomain() const;
69 }; 71 };
70 72
71 typedef intrusive_ptr<ElemHideBase> ElemHideBasePtr; 73 typedef intrusive_ptr<ElemHideBase> ElemHideBasePtr;
74
75 ABP_NS_END
LEFTRIGHT

Powered by Google App Engine
This is Rietveld