compiled/filter/ElemHideBase.h - Issue 29595633: Issue 5870 - Implement the new ElemHideEmulation filter type

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: compiled/filter/ElemHideBase.h

Issue 29595633: Issue 5870 - Implement the new ElemHideEmulation filter type (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/

Left Patch Set: Address review comment. Reworked the conversion Created Feb. 7, 2018, 4:13 a.m.

Right Patch Set: Deal with ill formed filters. Created Feb. 14, 2018, 5:05 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 /*	1 /*

2 * This file is part of Adblock Plus <https://adblockplus.org/>,	2 * This file is part of Adblock Plus <https://adblockplus.org/>,

3 * Copyright (C) 2006-present eyeo GmbH	3 * Copyright (C) 2006-present eyeo GmbH

4 *	4 *

5 * Adblock Plus is free software: you can redistribute it and/or modify	5 * Adblock Plus is free software: you can redistribute it and/or modify

6 * it under the terms of the GNU General Public License version 3 as	6 * it under the terms of the GNU General Public License version 3 as

7 * published by the Free Software Foundation.	7 * published by the Free Software Foundation.

8 *	8 *

9 * Adblock Plus is distributed in the hope that it will be useful,	9 * Adblock Plus is distributed in the hope that it will be useful,

10 * but WITHOUT ANY WARRANTY; without even the implied warranty of	10 * but WITHOUT ANY WARRANTY; without even the implied warranty of

11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the	11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the

12 * GNU General Public License for more details.	12 * GNU General Public License for more details.

13 *	13 *

14 * You should have received a copy of the GNU General Public License	14 * You should have received a copy of the GNU General Public License

15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.	15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.

16 */	16 */

17	17

18 #pragma once	18 #pragma once

19	19

20 #include <cstddef>	20 #include <cstddef>

21	21

	22 #include "../base.h"

22 #include "ActiveFilter.h"	23 #include "ActiveFilter.h"

23 #include "../bindings/runtime.h"	24 #include "../bindings/runtime.h"

	25

	26 ABP_NS_BEGIN

24	27

25 struct ElemHideData	28 struct ElemHideData

26 {	29 {

27 String::size_type mDomainsEnd;	30 String::size_type mDomainsEnd;

28 String::size_type mSelectorStart;	31 String::size_type mSelectorStart;

29	32

30 bool HasDomains() const	33 bool HasDomains() const

31 {	34 {

32 return mDomainsEnd != 0;	35 return mDomainsEnd != 0;

33 }	36 }

(...skipping 27 matching lines...) Expand all Loading...
61 static constexpr Type classType = Type::ELEMHIDEBASE;	64 static constexpr Type classType = Type::ELEMHIDEBASE;

62 explicit ElemHideBase(Type type, const String& text, const ElemHideData& data) ;	65 explicit ElemHideBase(Type type, const String& text, const ElemHideData& data) ;

63 static Type Parse(DependentString& text, ElemHideData& data, bool& needConvers ion);	66 static Type Parse(DependentString& text, ElemHideData& data, bool& needConvers ion);

64 static DependentString ConvertFilter(String& text, String::size_type& at);	67 static DependentString ConvertFilter(String& text, String::size_type& at);

65	68

66 OwnedString BINDINGS_EXPORTED GetSelector() const;	69 OwnedString BINDINGS_EXPORTED GetSelector() const;

67 OwnedString BINDINGS_EXPORTED GetSelectorDomain() const;	70 OwnedString BINDINGS_EXPORTED GetSelectorDomain() const;

68 };	71 };

69	72

70 typedef intrusive_ptr<ElemHideBase> ElemHideBasePtr;	73 typedef intrusive_ptr<ElemHideBase> ElemHideBasePtr;

	74

	75 ABP_NS_END

LEFT	RIGHT