Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: test/compiled/Filter.cpp

Issue 29595633: Issue 5870 - Implement the new ElemHideEmulation filter type (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/
Left Patch Set: Fix a few memory leaks (add ref issues) Created Feb. 9, 2018, 6:13 p.m.
Right Patch Set: Deal with ill formed filters. Created Feb. 14, 2018, 5:05 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details. 12 * GNU General Public License for more details.
13 * 13 *
14 * You should have received a copy of the GNU General Public License 14 * You should have received a copy of the GNU General Public License
15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. 15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
16 */ 16 */
17 17
18 #include "gtest/gtest.h" 18 #include <gtest/gtest.h>
19 #include "compiled/String.h" 19 #include "compiled/String.h"
20 #include "compiled/filter/Filter.h" 20 #include "compiled/filter/Filter.h"
21 #include "compiled/filter/ElemHideBase.h" 21 #include "compiled/filter/ElemHideBase.h"
22
23 ABP_NS_USING
22 24
23 TEST(TestFilter, testFromText) 25 TEST(TestFilter, testFromText)
24 { 26 {
25 OwnedString t(u"www.example.com#?#:-abp-properties(foo)"_str); 27 OwnedString t(u"www.example.com#?#:-abp-properties(foo)"_str);
26 DependentString text(t); 28 DependentString text(t);
27 29
28 FilterPtr filter(Filter::FromText(text), false); 30 FilterPtr filter(Filter::FromText(text), false);
29 EXPECT_EQ(filter->GetText(), u"www.example.com#?#:-abp-properties(foo)"_str); 31 EXPECT_EQ(filter->GetText(), u"www.example.com#?#:-abp-properties(foo)"_str);
30 } 32 }
31 33
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 FilterPtr filter(Filter::FromText(text), false); 76 FilterPtr filter(Filter::FromText(text), false);
75 EXPECT_FALSE(filter); 77 EXPECT_FALSE(filter);
76 } 78 }
77 { 79 {
78 OwnedString t(u"www.example.com#@#[-abp-properties='foo'bar']"_str); 80 OwnedString t(u"www.example.com#@#[-abp-properties='foo'bar']"_str);
79 DependentString text(t); 81 DependentString text(t);
80 82
81 FilterPtr filter(Filter::FromText(text), false); 83 FilterPtr filter(Filter::FromText(text), false);
82 EXPECT_FALSE(filter); 84 EXPECT_FALSE(filter);
83 } 85 }
86 {
87 OwnedString t(u"www.example.com#@#[-abp-properties='foo'bar]"_str);
88 DependentString text(t);
89
90 FilterPtr filter(Filter::FromText(text), false);
91 EXPECT_FALSE(filter);
92 }
93 {
94 OwnedString t(u"www.example.com#@#[-abp-properties=bar'foo']"_str);
95 DependentString text(t);
96
97 FilterPtr filter(Filter::FromText(text), false);
98 EXPECT_FALSE(filter);
99 }
84 } 100 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld