Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: compiled/filter/ElemHideBase.h

Issue 29595633: Issue 5870 - Implement the new ElemHideEmulation filter type (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/
Patch Set: Reworked the strings const. String::find() from a String::value_type* Created Feb. 1, 2018, 8:36 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « compiled/String.h ('k') | compiled/filter/ElemHideBase.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: compiled/filter/ElemHideBase.h
===================================================================
--- a/compiled/filter/ElemHideBase.h
+++ b/compiled/filter/ElemHideBase.h
@@ -21,16 +21,17 @@
#include "ActiveFilter.h"
#include "../bindings/runtime.h"
struct ElemHideData
{
String::size_type mDomainsEnd;
String::size_type mSelectorStart;
+ bool mNeedConversion;
bool HasDomains() const
{
return mDomainsEnd != 0;
}
DependentString GetDomainsSource(String& text) const
{
@@ -56,14 +57,15 @@
class ElemHideBase : public ActiveFilter
{
protected:
ElemHideData mData;
public:
static constexpr Type classType = Type::ELEMHIDEBASE;
explicit ElemHideBase(Type type, const String& text, const ElemHideData& data);
static Type Parse(DependentString& text, ElemHideData& data);
+ static OwnedString ConvertFilter(const String& text, String::size_type& at);
OwnedString BINDINGS_EXPORTED GetSelector() const;
OwnedString BINDINGS_EXPORTED GetSelectorDomain() const;
};
typedef intrusive_ptr<ElemHideBase> ElemHideBasePtr;
« no previous file with comments | « compiled/String.h ('k') | compiled/filter/ElemHideBase.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld