Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: test/subscriptionClasses.js

Issue 29595633: Issue 5870 - Implement the new ElemHideEmulation filter type (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/
Patch Set: Reworked the strings const. String::find() from a String::value_type* Created Feb. 1, 2018, 8:36 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/filterClasses.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/subscriptionClasses.js
===================================================================
--- a/test/subscriptionClasses.js
+++ b/test/subscriptionClasses.js
@@ -115,17 +115,21 @@
exports.testSubscriptionDefaults = function(test)
{
let tests = [
["blocking", "test"],
["whitelist", "@@test"],
["elemhide", "##test"],
["elemhide", "#@#test"],
- ["elemhide", "foo##[-abp-properties='foo']"],
+ ["elemhide", "foo##:-abp-properties(foo)"],
+ ["elemhide", "foo#?#:-abp-properties(foo)"],
+ // Invalid elemhide filter. Incorrectly classified as blocking.
+ // See https://issues.adblockplus.org/ticket/6234
+ ["blocking", "foo#@?#:-abp-properties(foo)"],
["", "!test"],
["", "/??/"],
["blocking whitelist", "test", "@@test"],
["blocking elemhide", "test", "##test"]
];
for (let [defaults, ...filters] of tests)
{
« no previous file with comments | « test/filterClasses.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld