Issue 5870 - Implement the new ElemHideEmulation filter type

compiled/filter/ElemHideBase.h

Index: compiled/filter/ElemHideBase.h
===================================================================
--- a/compiled/filter/ElemHideBase.h
+++ b/compiled/filter/ElemHideBase.h
@@ -21,16 +21,17 @@
 
 #include "ActiveFilter.h"
 #include "../bindings/runtime.h"
 
 struct ElemHideData
 {
   String::size_type mDomainsEnd;
   String::size_type mSelectorStart;
+  bool mNeedConversion;

[sergei, 2018/02/05 14:51:06]

Do we really need this member for each instance of ElemHideBase? What do you
think about detecting whether a conversion is required in the constructor of
ElemHideBase?

[hub, 2018/02/07 04:13:37]

I can move mNeedConversion out of this and pass it to ElemHideBase::Parse().

The conversion in the constructor is a problem as it involved mutating
data.elemhide as well.

 
   bool HasDomains() const
   {
     return mDomainsEnd != 0;
   }
 
   DependentString GetDomainsSource(String& text) const
   {
@@ -56,14 +57,15 @@
 class ElemHideBase : public ActiveFilter
 {
 protected:
   ElemHideData mData;
 public:
   static constexpr Type classType = Type::ELEMHIDEBASE;
   explicit ElemHideBase(Type type, const String& text, const ElemHideData& data);
   static Type Parse(DependentString& text, ElemHideData& data);
+  static OwnedString ConvertFilter(const String& text, String::size_type& at);
 
   OwnedString BINDINGS_EXPORTED GetSelector() const;
   OwnedString BINDINGS_EXPORTED GetSelectorDomain() const;
 };
 
 typedef intrusive_ptr<ElemHideBase> ElemHideBasePtr;