Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: compiled/filter/ElemHideBase.h

Issue 29595633: Issue 5870 - Implement the new ElemHideEmulation filter type (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/
Patch Set: Added missing ABP_NS macros Created Feb. 9, 2018, 8:34 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: compiled/filter/ElemHideBase.h
===================================================================
--- a/compiled/filter/ElemHideBase.h
+++ b/compiled/filter/ElemHideBase.h
@@ -58,17 +58,18 @@
class ElemHideBase : public ActiveFilter
{
protected:
ElemHideData mData;
public:
static constexpr Type classType = Type::ELEMHIDEBASE;
explicit ElemHideBase(Type type, const String& text, const ElemHideData& data);
- static Type Parse(DependentString& text, ElemHideData& data);
+ static Type Parse(DependentString& text, ElemHideData& data, bool& needConversion);
sergei 2018/02/12 12:53:20 Perhaps it makes sense just in case to add a comme
hub 2018/02/12 18:14:40 Instead I'll set it to false in there.
+ static DependentString ConvertFilter(String& text, String::size_type& at);
OwnedString BINDINGS_EXPORTED GetSelector() const;
OwnedString BINDINGS_EXPORTED GetSelectorDomain() const;
};
typedef intrusive_ptr<ElemHideBase> ElemHideBasePtr;
ABP_NS_END

Powered by Google App Engine
This is Rietveld