Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(75)

Issue 29596620: Issue 5983 - update Acceptable Ads Section wording (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 3 months ago by saroyanm
Modified:
2 years, 3 months ago
Reviewers:
Thomas Greiner, Lisa
CC:
saroyanm
Visibility:
Public.

Description

Issue 5983 - update Acceptable Ads Section wording

Patch Set 1 : #

Patch Set 2 : #

Total comments: 5

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -11 lines) Patch
M desktop-options.html View 2 chunks +1 line, -2 lines 0 comments Download
M locale/en_US/desktop-options.json View 1 chunk +1 line, -9 lines 0 comments Download

Messages

Total messages: 7
saroyanm
@Thomas can you please have a look.
2 years, 3 months ago (2017-11-03 12:52:28 UTC) #1
saroyanm
https://codereview.adblockplus.org/29596620/diff/29596633/locale/ru/desktop-options.json File locale/ru/desktop-options.json (left): https://codereview.adblockplus.org/29596620/diff/29596633/locale/ru/desktop-options.json#oldcode5 locale/ru/desktop-options.json:5: "options_acceptableAds_ads_description_2": { Should we in general remove translations ? ...
2 years, 3 months ago (2017-11-03 12:54:26 UTC) #2
Lisa
https://codereview.adblockplus.org/29596620/diff/29596633/locale/en_US/desktop-options.json File locale/en_US/desktop-options.json (right): https://codereview.adblockplus.org/29596620/diff/29596633/locale/en_US/desktop-options.json#newcode84 locale/en_US/desktop-options.json:84: "message": "<strong>Note:</strong> You have <strong>Do Not Track (DNT)</strong> disabled ...
2 years, 3 months ago (2017-11-03 12:59:00 UTC) #3
saroyanm
https://codereview.adblockplus.org/29596620/diff/29596633/locale/en_US/desktop-options.json File locale/en_US/desktop-options.json (right): https://codereview.adblockplus.org/29596620/diff/29596633/locale/en_US/desktop-options.json#newcode84 locale/en_US/desktop-options.json:84: "message": "<strong>Note:</strong> You have <strong>Do Not Track (DNT)</strong> disabled ...
2 years, 3 months ago (2017-11-03 13:02:11 UTC) #4
Thomas Greiner
LGTM https://codereview.adblockplus.org/29596620/diff/29596633/locale/ru/desktop-options.json File locale/ru/desktop-options.json (left): https://codereview.adblockplus.org/29596620/diff/29596633/locale/ru/desktop-options.json#oldcode5 locale/ru/desktop-options.json:5: "options_acceptableAds_ads_description_2": { On 2017/11/03 12:54:25, saroyanm wrote: > ...
2 years, 3 months ago (2017-11-03 13:53:21 UTC) #5
saroyanm
https://codereview.adblockplus.org/29596620/diff/29596633/locale/ru/desktop-options.json File locale/ru/desktop-options.json (left): https://codereview.adblockplus.org/29596620/diff/29596633/locale/ru/desktop-options.json#oldcode5 locale/ru/desktop-options.json:5: "options_acceptableAds_ads_description_2": { On 2017/11/03 13:53:20, Thomas Greiner wrote: > ...
2 years, 3 months ago (2017-11-03 14:07:27 UTC) #6
Thomas Greiner
2 years, 3 months ago (2017-11-03 15:07:25 UTC) #7
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5