skin/icons/checkmark.svg - Issue 29596678: Issue 5973 - broken icons on Firefox v50-53

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: skin/icons/checkmark.svg

Issue 29596678: Issue 5973 - broken icons on Firefox v50-53 (Closed)

Patch Set: Use IDs for shared icons Created Nov. 3, 2017, 6:25 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <svg id="c7a84ece-d790-40f5-a9a3-952827e82ab7" data-name="artwork" xmlns="http:/ /www.w3.org/2000/svg" viewBox="10 10 30 30"><title>checkmark</title><polygon poi nts="20.49 31.17 13.29 23.98 14.71 22.56 20.49 28.34 33.29 15.54 34.71 16.95 20. 49 31.17"/></svg>	1 <svg xmlns="http://www.w3.org/2000/svg">

	2 <view id="default" viewBox="10 10 30 30"/>

	3 <polygon points="20.49 31.17 13.29 23.98 14.71 22.56 20.49 28.34 33.29 15.54 3 4.71 16.95 20.49 31.17" fill="#BBB"/>

	4

	5 <view id="approve" viewBox="10 40 30 30"/>
	Thomas Greiner 2017/11/03 19:04:10 Detail: I'd suggest calling it "approved" since "a Detail: I'd suggest calling it "approved" since "approve" is a verb, not an adjective which would be more fitting for describing a state. saroyanm 2017/11/03 19:18:16 agree Show quoted text On 2017/11/03 19:04:10, Thomas Greiner wrote: > Detail: I'd suggest calling it "approved" since "approve" is a verb, not an > adjective which would be more fitting for describing a state. agree saroyanm 2017/11/03 19:35:08 Done. Show quoted text On 2017/11/03 19:18:16, saroyanm wrote: > On 2017/11/03 19:04:10, Thomas Greiner wrote: > > Detail: I'd suggest calling it "approved" since "approve" is a verb, not an > > adjective which would be more fitting for describing a state. > > agree Done.
	6 <polygon points="20.49 31.17 13.29 23.98 14.71 22.56 20.49 28.34 33.29 15.54 3 4.71 16.95 20.49 31.17" transform="translate(0, 30)" fill="#008000"/>
	Thomas Greiner 2017/11/03 19:04:10 Detail: According to the options page style guide, Detail: According to the options page style guide, the color green is specified as "#43A548". saroyanm 2017/11/03 19:18:16 I can't see it specified, but I'd rather keep the Show quoted text On 2017/11/03 19:04:10, Thomas Greiner wrote: > Detail: According to the options page style guide, the color green is specified > as "#43A548". I can't see it specified, but I'd rather keep the colors as they used to be before this change and address color change separately.
	7 </svg>

OLD	NEW

« no previous file with comments | « skin/icons/attention.svg ('k') | skin/icons/code.svg » ('j') | skin/icons/delete.svg » ('J')