skin/icons/delete.svg - Issue 29596678: Issue 5973 - broken icons on Firefox v50-53

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: skin/icons/delete.svg

Issue 29596678: Issue 5973 - broken icons on Firefox v50-53 (Closed)

Patch Set: Use IDs for shared icons Created Nov. 3, 2017, 6:25 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <svg id="5dbfc7a9-72c4-4898-881d-75bf73a9a059" data-name="artwork" xmlns="http:/ /www.w3.org/2000/svg" viewBox="0 0 48 48"><title>delete</title><polygon points=" 42.71 6.71 41.29 5.29 24 22.59 6.71 5.29 5.29 6.71 22.59 24 5.29 41.29 6.71 42.7 1 24 25.41 41.29 42.71 42.71 41.29 25.41 24 42.71 6.71"/></svg>	1 <svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 48 48">

	2 <view id="primary" viewBox="0 0 48 48"/>

	3 <polygon points="42.71 6.71 41.29 5.29 24 22.59 6.71 5.29 5.29 6.71 22.59 24 5 .29 41.29 6.71 42.71 24 25.41 41.29 42.71 42.71 41.29 25.41 24 42.71 6.71" fill= "#FFF"/>
	Thomas Greiner 2017/11/03 19:04:10 Detail: Is this color meant to be completely white Detail: Is this color meant to be completely white or `#F3F3F3` as specified in the options page style guide? saroyanm 2017/11/03 19:18:16 I can't see this color being specified, but I'd ra Show quoted text On 2017/11/03 19:04:10, Thomas Greiner wrote: > Detail: Is this color meant to be completely white or `#F3F3F3` as specified in > the options page style guide? I can't see this color being specified, but I'd rather keep current color for now, as it has been used beforehand as well.
	4

	5 <view id="primary-hover" viewBox="0 48 48 48"/>

	6 <polygon points="42.71 6.71 41.29 5.29 24 22.59 6.71 5.29 5.29 6.71 22.59 24 5 .29 41.29 6.71 42.71 24 25.41 41.29 42.71 42.71 41.29 25.41 24 42.71 6.71" trans form="translate(0, 48)" fill="#000"/>

	7

	8 <view id="secondary" viewBox="0 96 48 48"/>

	9 <polygon points="42.71 6.71 41.29 5.29 24 22.59 6.71 5.29 5.29 6.71 22.59 24 5 .29 41.29 6.71 42.71 24 25.41 41.29 42.71 42.71 41.29 25.41 24 42.71 6.71" trans form="translate(0, 96)" fill="#099DD1"/>

	10

	11 <view id="secondary-hover" viewBox="0 144 48 48"/>

	12 <polygon points="42.71 6.71 41.29 5.29 24 22.59 6.71 5.29 5.29 6.71 22.59 24 5 .29 41.29 6.71 42.71 24 25.41 41.29 42.71 42.71 41.29 25.41 24 42.71 6.71" trans form="translate(0, 144)" fill="#5CBCE1"/>

	13 </svg>

OLD	NEW

« skin/icons/checkmark.svg ('K') | « skin/icons/code.svg ('k') | skin/icons/gear.svg » ('j') | skin/icons/gear.svg » ('J')