skin/icons/gear.svg - Issue 29596678: Issue 5973 - broken icons on Firefox v50-53

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: skin/icons/gear.svg

Issue 29596678: Issue 5973 - broken icons on Firefox v50-53 (Closed)

Patch Set: Use IDs for shared icons Created Nov. 3, 2017, 6:25 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <svg id="eae6d08d-cad8-474a-8dd3-1c64015bd949" data-name="artwork" xmlns="http:/ /www.w3.org/2000/svg" viewBox="0 0 48 48"><title>settings</title><path d="M42.3, 26.4c0-.72.25-1.68.25-2.4a8,8,0,0,0-.25-2.4L47.48,18a1.1,1.1,0,0,0,.25-1.68l-4.9 4-8.4a1.11,1.11,0,0,0-1.48-.72L35.39,9.84a15.85,15.85,0,0,0-4.44-2.4L30.21,1.2A1 .15,1.15,0,0,0,29,0H19.1a1.15,1.15,0,0,0-1.23,1.2l-.74,6a19.11,19.11,0,0,0-4.44, 2.4L6.76,7.2a1.2,1.2,0,0,0-1.48.48L.34,16.08c-.49.72-.49,1.44.25,1.68L5.77,21.6c 0,.72-.25,1.68-.25,2.4a8,8,0,0,0,.25,2.4L.59,30a1.1,1.1,0,0,0-.25,1.68l4.94,8.4a 1.11,1.11,0,0,0,1.48.72l5.92-2.64a15.85,15.85,0,0,0,4.44,2.4l.74,6.24A1.15,1.15, 0,0,0,19.1,48H29a1.15,1.15,0,0,0,1.23-1.2l.74-6.24a19.11,19.11,0,0,0,4.44-2.4l5. 92,2.64a1.2,1.2,0,0,0,1.48-.48l4.94-8.4a1.45,1.45,0,0,0-.25-1.68ZM24,34A10,10,0, 1,1,34,24,10,10,0,0,1,24,34Z"/></svg>	1 <svg xmlns="http://www.w3.org/2000/svg">

	2 <view id="default" viewBox="0 0 48 48"/>

	3 <path d="M42.3,26.4c0-.72.25-1.68.25-2.4a8,8,0,0,0-.25-2.4L47.48,18a1.1,1.1,0, 0,0,.25-1.68l-4.94-8.4a1.11,1.11,0,0,0-1.48-.72L35.39,9.84a15.85,15.85,0,0,0-4.4 4-2.4L30.21,1.2A1.15,1.15,0,0,0,29,0H19.1a1.15,1.15,0,0,0-1.23,1.2l-.74,6a19.11, 19.11,0,0,0-4.44,2.4L6.76,7.2a1.2,1.2,0,0,0-1.48.48L.34,16.08c-.49.72-.49,1.44.2 5,1.68L5.77,21.6c0,.72-.25,1.68-.25,2.4a8,8,0,0,0,.25,2.4L.59,30a1.1,1.1,0,0,0-. 25,1.68l4.94,8.4a1.11,1.11,0,0,0,1.48.72l5.92-2.64a15.85,15.85,0,0,0,4.44,2.4l.7 4,6.24A1.15,1.15,0,0,0,19.1,48H29a1.15,1.15,0,0,0,1.23-1.2l.74-6.24a19.11,19.11, 0,0,0,4.44-2.4l5.92,2.64a1.2,1.2,0,0,0,1.48-.48l4.94-8.4a1.45,1.45,0,0,0-.25-1.6 8ZM24,34A10,10,0,1,1,34,24,10,10,0,0,1,24,34Z" fill="#099DD1"/>
	Thomas Greiner 2017/11/03 19:04:10 Detail: Where is this color coming from? I can't f Detail: Where is this color coming from? I can't find it in the options page style guide color palette. I'm also seeing it being used in a bunch of other SVGs. saroyanm 2017/11/03 19:18:16 This is old, color, not all color changes has been Show quoted text On 2017/11/03 19:04:10, Thomas Greiner wrote: > Detail: Where is this color coming from? I can't find it in the options page > style guide color palette. > > I'm also seeing it being used in a bunch of other SVGs. This is old, color, not all color changes has been addressed, as specification used to keep being updated, see -> https://bitbucket.org/adblockplus/spec/src/a3834cf44ff721fa4b3679fcda46b8fe05... I think we should keep this color and updated accordingly all instances in future.
	4

	5 <view id="hover" viewBox="0 48 48 48"/>

	6 <path d="M42.3,26.4c0-.72.25-1.68.25-2.4a8,8,0,0,0-.25-2.4L47.48,18a1.1,1.1,0, 0,0,.25-1.68l-4.94-8.4a1.11,1.11,0,0,0-1.48-.72L35.39,9.84a15.85,15.85,0,0,0-4.4 4-2.4L30.21,1.2A1.15,1.15,0,0,0,29,0H19.1a1.15,1.15,0,0,0-1.23,1.2l-.74,6a19.11, 19.11,0,0,0-4.44,2.4L6.76,7.2a1.2,1.2,0,0,0-1.48.48L.34,16.08c-.49.72-.49,1.44.2 5,1.68L5.77,21.6c0,.72-.25,1.68-.25,2.4a8,8,0,0,0,.25,2.4L.59,30a1.1,1.1,0,0,0-. 25,1.68l4.94,8.4a1.11,1.11,0,0,0,1.48.72l5.92-2.64a15.85,15.85,0,0,0,4.44,2.4l.7 4,6.24A1.15,1.15,0,0,0,19.1,48H29a1.15,1.15,0,0,0,1.23-1.2l.74-6.24a19.11,19.11, 0,0,0,4.44-2.4l5.92,2.64a1.2,1.2,0,0,0,1.48-.48l4.94-8.4a1.45,1.45,0,0,0-.25-1.6 8ZM24,34A10,10,0,1,1,34,24,10,10,0,0,1,24,34Z" transform="translate(0, 48)" fill ="#5CBCE1"/>

	7 </svg>

OLD	NEW

« skin/icons/delete.svg ('K') | « skin/icons/delete.svg ('k') | skin/icons/globe.svg » ('j') | skin/icons/tooltip.svg » ('J')