skin/icons/tooltip.svg - Issue 29596678: Issue 5973 - broken icons on Firefox v50-53

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: skin/icons/tooltip.svg

Issue 29596678: Issue 5973 - broken icons on Firefox v50-53 (Closed)

Patch Set: Use IDs for shared icons Created Nov. 3, 2017, 6:25 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <svg id="8c46c7bc-3457-406a-9a79-62c8849fc98c" data-name="artwork" xmlns="http:/ /www.w3.org/2000/svg" viewBox="0 0 48 48"><title>tooltip</title><path d="M24,0A2 4,24,0,1,0,48,24,24,24,0,0,0,24,0Zm0,46A22,22,0,1,1,46,24,22,22,0,0,1,24,46Z"/>< path d="M23.24,28.26a1.82,1.82,0,0,0-1.38.57,2.21,2.21,0,0,0,0,2.91,1.82,1.82,0, 0,0,1.38.57,1.87,1.87,0,0,0,1.39-.57,2.17,2.17,0,0,0,0-2.91A1.87,1.87,0,0,0,23.2 4,28.26Z"/><path d="M26.88,15.36a4.35,4.35,0,0,0-1.53-.82,6.48,6.48,0,0,0-1.92-. 27,5.21,5.21,0,0,0-2.57.64,7,7,0,0,0-2,1.63l1.66,1.53a4.93,4.93,0,0,1,1.22-1,2.9 3,2.93,0,0,1,1.46-.36,2,2,0,0,1,2.11,2.08A2.29,2.29,0,0,1,25,19.91,7.33,7.33,0,0 ,1,24.32,21q-.43.53-.91,1.09a8,8,0,0,0-.86,1.21A5.49,5.49,0,0,0,22,24.7a4.47,4.4 7,0,0,0-.07,1.72h2.63a3.2,3.2,0,0,1,.14-1.51,5.93,5.93,0,0,1,.65-1.27,9.44,9.44, 0,0,1,.91-1.14,13.28,13.28,0,0,0,.95-1.14,6.89,6.89,0,0,0,.74-1.26,3.6,3.6,0,0,0 ,.3-1.5,4.65,4.65,0,0,0-.35-1.87A3.63,3.63,0,0,0,26.88,15.36Z"/></svg>	1 <svg id="8c46c7bc-3457-406a-9a79-62c8849fc98c" data-name="artwork" xmlns="http:/ /www.w3.org/2000/svg" viewBox="0 0 48 48" fill="#099DD1">
	Thomas Greiner 2017/11/03 19:04:10 Doesn't `<svg fill="...">` apply the color to the Doesn't `<svg fill="...">` apply the color to the entire SVG rather than to the `<path>` elements? I assume not since you probably tested it but it still seems counter-intuitive. Thomas Greiner 2017/11/03 19:04:10 Detail: You've been cleaning up the SVG but I noti Detail: You've been cleaning up the SVG but I noticed that there's still some meta data attached to the `<svg>` tag so we could clean that up as well. saroyanm 2017/11/03 19:18:16 agree. Show quoted text On 2017/11/03 19:04:10, Thomas Greiner wrote: > Doesn't `<svg fill="...">` apply the color to the entire SVG rather than to the > `<path>` elements? I assume not since you probably tested it but it still seems > counter-intuitive. agree. saroyanm 2017/11/03 19:18:16 Yes, missed that, will update. Show quoted text On 2017/11/03 19:04:10, Thomas Greiner wrote: > Detail: You've been cleaning up the SVG but I noticed that there's still some > meta data attached to the `<svg>` tag so we could clean that up as well. Yes, missed that, will update. saroyanm 2017/11/03 19:35:08 Done. Show quoted text On 2017/11/03 19:18:16, saroyanm wrote: > On 2017/11/03 19:04:10, Thomas Greiner wrote: > > Doesn't `<svg fill="...">` apply the color to the entire SVG rather than to > the > > `<path>` elements? I assume not since you probably tested it but it still > seems > > counter-intuitive. > > agree. Done. saroyanm 2017/11/03 19:35:08 Done. Show quoted text On 2017/11/03 19:18:16, saroyanm wrote: > On 2017/11/03 19:04:10, Thomas Greiner wrote: > > Detail: You've been cleaning up the SVG but I noticed that there's still some > > meta data attached to the `<svg>` tag so we could clean that up as well. > > Yes, missed that, will update. Done.
	2 <path d="M24,0A24,24,0,1,0,48,24,24,24,0,0,0,24,0Zm0,46A22,22,0,1,1,46,24,22,2 2,0,0,1,24,46Z"/>

	3 <path d="M23.24,28.26a1.82,1.82,0,0,0-1.38.57,2.21,2.21,0,0,0,0,2.91,1.82,1.82 ,0,0,0,1.38.57,1.87,1.87,0,0,0,1.39-.57,2.17,2.17,0,0,0,0-2.91A1.87,1.87,0,0,0,2 3.24,28.26Z"/>

	4 <path d="M26.88,15.36a4.35,4.35,0,0,0-1.53-.82,6.48,6.48,0,0,0-1.92-.27,5.21,5 .21,0,0,0-2.57.64,7,7,0,0,0-2,1.63l1.66,1.53a4.93,4.93,0,0,1,1.22-1,2.93,2.93,0, 0,1,1.46-.36,2,2,0,0,1,2.11,2.08A2.29,2.29,0,0,1,25,19.91,7.33,7.33,0,0,1,24.32, 21q-.43.53-.91,1.09a8,8,0,0,0-.86,1.21A5.49,5.49,0,0,0,22,24.7a4.47,4.47,0,0,0-. 07,1.72h2.63a3.2,3.2,0,0,1,.14-1.51,5.93,5.93,0,0,1,.65-1.27,9.44,9.44,0,0,1,.91 -1.14,13.28,13.28,0,0,0,.95-1.14,6.89,6.89,0,0,0,.74-1.26,3.6,3.6,0,0,0,.3-1.5,4 .65,4.65,0,0,0-.35-1.87A3.63,3.63,0,0,0,26.88,15.36Z"/>

	5 </svg>

OLD	NEW

« skin/icons/gear.svg ('K') | « skin/icons/reload.svg ('k') | skin/icons/trash.svg » ('j') | skin/icons/trash.svg » ('J')