Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: skin/icons/delete.svg

Issue 29596678: Issue 5973 - broken icons on Firefox v50-53 (Closed)
Patch Set: Use IDs for shared icons Created Nov. 3, 2017, 6:25 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: skin/icons/delete.svg
===================================================================
--- a/skin/icons/delete.svg
+++ b/skin/icons/delete.svg
@@ -1,1 +1,13 @@
-<svg id="5dbfc7a9-72c4-4898-881d-75bf73a9a059" data-name="artwork" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 48 48"><title>delete</title><polygon points="42.71 6.71 41.29 5.29 24 22.59 6.71 5.29 5.29 6.71 22.59 24 5.29 41.29 6.71 42.71 24 25.41 41.29 42.71 42.71 41.29 25.41 24 42.71 6.71"/></svg>
+<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 48 48">
+ <view id="primary" viewBox="0 0 48 48"/>
+ <polygon points="42.71 6.71 41.29 5.29 24 22.59 6.71 5.29 5.29 6.71 22.59 24 5.29 41.29 6.71 42.71 24 25.41 41.29 42.71 42.71 41.29 25.41 24 42.71 6.71" fill="#FFF"/>
Thomas Greiner 2017/11/03 19:04:10 Detail: Is this color meant to be completely white
saroyanm 2017/11/03 19:18:16 I can't see this color being specified, but I'd ra
+
+ <view id="primary-hover" viewBox="0 48 48 48"/>
+ <polygon points="42.71 6.71 41.29 5.29 24 22.59 6.71 5.29 5.29 6.71 22.59 24 5.29 41.29 6.71 42.71 24 25.41 41.29 42.71 42.71 41.29 25.41 24 42.71 6.71" transform="translate(0, 48)" fill="#000"/>
+
+ <view id="secondary" viewBox="0 96 48 48"/>
+ <polygon points="42.71 6.71 41.29 5.29 24 22.59 6.71 5.29 5.29 6.71 22.59 24 5.29 41.29 6.71 42.71 24 25.41 41.29 42.71 42.71 41.29 25.41 24 42.71 6.71" transform="translate(0, 96)" fill="#099DD1"/>
+
+ <view id="secondary-hover" viewBox="0 144 48 48"/>
+ <polygon points="42.71 6.71 41.29 5.29 24 22.59 6.71 5.29 5.29 6.71 22.59 24 5.29 41.29 6.71 42.71 24 25.41 41.29 42.71 42.71 41.29 25.41 24 42.71 6.71" transform="translate(0, 144)" fill="#5CBCE1"/>
+</svg>

Powered by Google App Engine
This is Rietveld