Issue 5977 - Set popup programmatically on Firefox

lib/options.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 106 matching lines @@
       // We use a relative URL here because of this Edge issue:
       // https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/10276332
       browser.tabs.create({url: optionsUrl}, () =>
       {
         returnShowOptionsCall(optionsTab, callback);
       });
     }
   });
 };
 
+// We need to clear the popup URL on Firefox for Android in order for the
+// options page to open instead of the bubble. Unfortunately there's a bug[1]
+// which prevents us from doing that, so we must avoid setting the URL on
+// Firefox from the manifest at all, instead setting it here only for
+// non-mobile.
+// [1] - https://bugzilla.mozilla.org/show_bug.cgi?id=1414613
+if (info.application == "firefox")

[Manish Jethani, 2017/11/06 14:15:10]

Firefox 50 doesn't have runtime.getBrowserInfo so info.application will be set
to "firefox" already.

+{
+  browser.browserAction.setPopup({popup: "popup.html"});
+}
+else if (info.platform == "gecko")

[Manish Jethani, 2017/11/06 14:15:10]

We can restrict this to Gecko-based browsers so we don't have to do any checks
(e.g. checking for runtime.getBrowserInfo, which is not available on other
platforms).

+{
+  browser.runtime.getBrowserInfo().then(browserInfo =>
+  {
+    if (browserInfo.name != "Fennec")
+      browser.browserAction.setPopup({popup: "popup.html"});
+  });
+}
+
 // On Firefox for Android, open the options page directly when the browser
 // action is clicked.
 browser.browserAction.onClicked.addListener(() =>
 {
   browser.tabs.query({active: true, lastFocusedWindow: true}, ([tab]) =>
   {
     let currentPage = new ext.Page(tab);
 
     showOptions(optionsPage =>
     {
       if (!/^https?:$/.test(currentPage.url.protocol))
         return;
 
       optionsPage.sendMessage({
         type: "app.respond",
         action: "showPageOptions",
         args: [
           {
             host: getDecodedHostname(currentPage.url).replace(/^www\./, ""),
             whitelisted: !!checkWhitelisted(currentPage)
           }
         ]
       });
     });
   });
 });