metadata.gecko - Issue 29597555: Issue 5977 - Set popup programmatically on Firefox

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: metadata.gecko

Issue 29597555: Issue 5977 - Set popup programmatically on Firefox (Closed) Base URL: https://hg.adblockplus.org/adblockpluschrome/

Left Patch Set: Created Nov. 4, 2017, 11:22 a.m.

Right Patch Set: Update buildtools dependency Created Nov. 17, 2017, 3:08 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 [default]	1 [default]

2 inherit = metadata.chrome	2 inherit = metadata.chrome

3	3

4 [general]	4 [general]

5 id={d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}	5 id={d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}

6 basename = adblockplusfirefox	6 basename = adblockplusfirefox

7 version = 2.99.0

8 browserAction -= popup.html	7 browserAction -= popup.html
Manish Jethani 2017/11/04 11:27:18 This also needs a change in buildtools. If this ap This also needs a change in buildtools. If this approach looks good, I can file an issue and upload a separate patch for it. kzar 2017/11/04 16:17:26 I think your approach is OK. Show quoted text On 2017/11/04 11:27:18, Manish Jethani wrote: > This also needs a change in buildtools. If this approach looks good, I can file > an issue and upload a separate patch for it. I think your approach is OK.
9	8

10 [compat]	9 [compat]

11 gecko = 50.0	10 gecko = 50.0

12	11

13 [mapping]	12 [mapping]

14 mobile-options.html = adblockplusui/mobile-options.html	13 mobile-options.html = adblockplusui/mobile-options.html

15 mobile-options.js = adblockplusui/mobile-options.js	14 mobile-options.js = adblockplusui/mobile-options.js

16 desktop-options.html = adblockplusui/desktop-options.html	15 desktop-options.html = adblockplusui/desktop-options.html

17 desktop-options.js = adblockplusui/desktop-options.js	16 desktop-options.js = adblockplusui/desktop-options.js

18 skin/desktop-options.css = adblockplusui/skin/desktop-options.css	17 skin/desktop-options.css = adblockplusui/skin/desktop-options.css

(...skipping 16 matching lines...) Expand all Loading...
35 skin/social/facebook.svg = adblockplusui/skin/social/facebook.svg	34 skin/social/facebook.svg = adblockplusui/skin/social/facebook.svg

36 skin/social/googleplus.svg = adblockplusui/skin/social/googleplus.svg	35 skin/social/googleplus.svg = adblockplusui/skin/social/googleplus.svg

37	36

38 [bundles]	37 [bundles]

39 lib/adblockplus.js += lib/firefoxDataCleanup.js	38 lib/adblockplus.js += lib/firefoxDataCleanup.js

40	39

41 [import_locales]	40 [import_locales]

42 adblockplusui/locale//mobile-options.json =	41 adblockplusui/locale//mobile-options.json =

43 adblockplusui/locale//desktop-options.json =	42 adblockplusui/locale//desktop-options.json =

44 adblockplusui/locale//common.json =	43 adblockplusui/locale//common.json =

LEFT	RIGHT