Issue 5977 - Set popup programmatically on Firefox

lib/options.js

Index: lib/options.js
===================================================================
--- a/lib/options.js
+++ b/lib/options.js
@@ -119,16 +119,35 @@
       browser.tabs.create({url: optionsUrl}, () =>
       {
         returnShowOptionsCall(optionsTab, callback);
       });
     }
   });
 };
 
+// We need to clear the popup URL on Firefox for Android in order for the
+// options page to open instead of the bubble. Unfortunately there's a bug[1]
+// which prevents us from doing that, so we must avoid setting the URL on
+// Firefox from the manifest at all, instead setting it here only for
+// non-mobile.
+// [1] - https://bugzilla.mozilla.org/show_bug.cgi?id=1414613
+if (info.application == "firefox")
+{
+  browser.browserAction.setPopup({popup: "popup.html"});
+}
+else if (info.platform == "gecko")
+{
+  browser.runtime.getBrowserInfo().then(browserInfo =>
+  {
+    if (browserInfo.name != "Fennec")
+      browser.browserAction.setPopup({popup: "popup.html"});
+  });
+}

[Wladimir Palant, 2017/11/06 15:04:31]

If we are choosing that approach, I wonder whether we should still have special
logic for Gecko. It could be:

  if (typeof browser.runtime.getBrowserInfo == "function")
    set popup conditionally, not for fennec
  else
    set popup unconditionally

[Manish Jethani, 2017/11/13 10:42:13]

I was hoping to restrict this to Gecko only to avoid any unintended side
effects, but I guess it's OK to make it generic. I've made the change and tested
it on Firefox (desktop and mobile) and Chrome now and it works OK.

Done.

+
 // On Firefox for Android, open the options page directly when the browser
 // action is clicked.
 browser.browserAction.onClicked.addListener(() =>
 {
   browser.tabs.query({active: true, lastFocusedWindow: true}, ([tab]) =>
   {
     let currentPage = new ext.Page(tab);