Issue 5980 - Use correct browser logos for browser select on help.eyeo.com

Issue 5980 - Use correct browser logos for browser select on help.eyeo.com

[ire, 2017-11-05 18:26:59]

The way Martin wants this to work is like this: All of the icons will be grayed
out with less opacity except for the currently selected one (and I took this
further and included the browser being currently hovered over).

The method I have used to have grayed out icons doesn't work on IE 10&11. The
only other method I can think of will require having two sets of images (one
gray, one colour), and swapping out the urls. 

I don't know if this is worth it, as IMO having the icons less opaque still
works and graying them out is an enhancement, not really a requirement. What do
you think?

https://codereview.adblockplus.org/29598558/diff/29598559/globals/browsers.py
File globals/browsers.py (right):

https://codereview.adblockplus.org/29598558/diff/29598559/globals/browsers.py...
globals/browsers.py:35: 'id': 'msie',
These changes will no longer be needed after
https://codereview.adblockplus.org/29598555/

[juliandoucette, 2017-11-06 10:39:35]

LGTM

> I don't know if this is worth it, as IMO having the icons less opaque still
> works and graying them out is an enhancement, not really a requirement. What
do
> you think?

I don't think that the old IE and FF fixes are necessary.

https://codereview.adblockplus.org/29598558/diff/29598583/static/img/svg/ios.svg
File static/img/svg/ios.svg (right):

https://codereview.adblockplus.org/29598558/diff/29598583/static/img/svg/ios....
static/img/svg/ios.svg:1: <?xml version="1.0" encoding="UTF-8"?>
NIT: This icon looks larger than the rest?

[ire, 2017-11-07 07:23:59]

On 2017/11/06 10:39:35, juliandoucette wrote:
> LGTM
> 
> > I don't know if this is worth it, as IMO having the icons less opaque still
> > works and graying them out is an enhancement, not really a requirement. What
> do
> > you think?
> 
> I don't think that the old IE and FF fixes are necessary.

Alright then. I'll leave the fallback for IE6-9 since IE9 is supported, but I'll
remove the other for old Firefox versions since it seems more "hacky" to me.

https://codereview.adblockplus.org/29598558/diff/29598583/static/img/svg/ios.svg
File static/img/svg/ios.svg (right):

https://codereview.adblockplus.org/29598558/diff/29598583/static/img/svg/ios....
static/img/svg/ios.svg:1: <?xml version="1.0" encoding="UTF-8"?>
On 2017/11/06 10:39:35, juliandoucette wrote:
> NIT: This icon looks larger than the rest?

I think it's just the shape of it that makes it look slightly bigger. I don't
think the difference is really noticeable though (to me anyway, I don't really
see it)