Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(70)

Issue 29599568: Issue 5969 - Add .unstyled utility class to website-defaults (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years ago by ire
Modified:
2 years ago
Reviewers:
juliandoucette
Base URL:
https://hg.adblockplus.org/website-defaults
Visibility:
Public.

Description

Issue 5969 - Add .unstyled utility class to website-defaults

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M static/scss/_utilities.scss View 1 chunk +17 lines, -0 lines 4 comments Download

Messages

Total messages: 3
ire
2 years ago (2017-11-06 08:34:15 UTC) #1
juliandoucette
LGTM https://codereview.adblockplus.org/29599568/diff/29599569/static/scss/_utilities.scss File static/scss/_utilities.scss (right): https://codereview.adblockplus.org/29599568/diff/29599569/static/scss/_utilities.scss#newcode96 static/scss/_utilities.scss:96: /* Unstyled elements TOL: .unstyle or .unstyled? https://codereview.adblockplus.org/29599568/diff/29599569/static/scss/_utilities.scss#newcode99 ...
2 years ago (2017-11-06 10:30:48 UTC) #2
ire
2 years ago (2017-11-06 14:32:57 UTC) #3
https://codereview.adblockplus.org/29599568/diff/29599569/static/scss/_utilit...
File static/scss/_utilities.scss (right):

https://codereview.adblockplus.org/29599568/diff/29599569/static/scss/_utilit...
static/scss/_utilities.scss:96: /* Unstyled elements
On 2017/11/06 10:30:48, juliandoucette wrote:
> TOL: .unstyle or .unstyled?

*shrugs* I'll keep it as unstyled for now

https://codereview.adblockplus.org/29599568/diff/29599569/static/scss/_utilit...
static/scss/_utilities.scss:99: .unstyled,
On 2017/11/06 10:30:48, juliandoucette wrote:
> TOL: .unstyled could apply to children too if you `.unstyled *`

Good idea. Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5