OffTopic: DependencyUpdater

eyeo-depup/src/templates/default.trac

+{#
+This file is part of Adblock Plus <https://adblockplus.org/>,
+Copyright (C) 2006-present eyeo GmbH
+
+Adblock Plus is free software: you can redistribute it and/or modify
+it under the terms of the GNU General Public License version 3 as
+published by the Free Software Foundation.
+
+Adblock Plus is distributed in the hope that it will be useful,
+but WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+GNU General Public License for more details.
+
+You should have received a copy of the GNU General Public License
+along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
+#}
+
+SUBJECT:
+Update {{ repository }} dependency to {{ hg_hash }}

[kzar, 2017/11/27 15:03:33]

Nit: Mind removing "SUBJECT: " and changing adding "revision"?

"Update {{ repository }} dependency to revision { hg_hash }}"

+
+=== Background ===
+

[kzar, 2017/11/27 15:03:32]

Nit: This blank line is inconsistent with the other sections.

+CHANGE ME!
+
+=== Included changes in `{{ repository }}` ===
+The list of changes imported by this is:
+[[TicketQuery({%- for issue_id in issue_ids -%}
+    id={{ issue_id }}{%- if not loop.last -%}&{%- endif -%}
+{%- endfor -%}
+,order=id,desc=1,format=table,col=summary|component)]]
+
+{% for change in noissues -%}
+|| [{{ change.hg_url }} {{ change.hg_hash }}] || {{ change.message }} || {{ change.author }} ||
+{% endfor %}
+
+=== What to change ===
+Update the `{{ repository }}` dependency to:
+
+|| **mercurial** || **git** ||
+|| {{ hg_hash }} || {{ git_hash }} ||
+

[Sebastian Noack, 2018/06/01 18:08:16]

In case of a buildtools dependency update you also have to run
./ensure_depedencies.py (in order to update the contents of
ensure_depedencies.py if there were any changes). I wonder whether we should add
something like this here:

  {% if repository == 'buildtools' -%}
  Run `./ensure_depedencies.py`.
  {%- endif %}

+=== Integration Notes ===
+

[kzar, 2017/11/27 15:03:32]

Nit: Another extra blank line.

+CHANGE ME!
+
+=== Hints for testers ===
+

[kzar, 2017/11/27 15:03:33]

Nit: Another extra blank line.

+CHANGE ME!