Issue 6001 - Pass IV8IsolateProvider to Helper

libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockHelper.java

Index: libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockHelper.java
diff --git a/libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockHelper.java b/libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockHelper.java
index 4a16625a1fbd269d746c03ca15dc3e277629e2cb..965bafcbc97203707c19a503e44d02894808da06 100644
--- a/libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockHelper.java
+++ b/libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockHelper.java
@@ -59,7 +59,7 @@ public class AdblockHelper
   private AdblockEngine engine;
   private AdblockSettingsStorage storage;
   private CountDownLatch engineCreated;
-  private Long v8IsolatePtr;
+  private Long v8IsolateProviderPtr;
 
   /*
     Simple ARC management for AdblockEngine
@@ -132,9 +132,10 @@ public class AdblockHelper
     return this;
   }
 
-  public void useV8Isolate(long ptr)
+  public AdblockHelper useV8IsolateProvider(long ptr)
   {
-    this.v8IsolatePtr = ptr;
+    this.v8IsolateProviderPtr = ptr;
+    return this;

[sergei, 2017/11/07 09:58:45]

Changing of the return value is an unrelated change but it's fine for me.

[anton, 2017/11/07 10:17:05]

Agree it's unrelated in general.
Just want to keep it more close to `Builder` pattern as we change method
signature anyway so now it's suitable time.

   }
 
   private void createAdblock()
@@ -158,9 +159,9 @@ public class AdblockHelper
       .setIsAllowedConnectionCallback(isAllowedConnectionCallback)
       .enableElementHiding(true);
 
-    if (v8IsolatePtr != null)
+    if (v8IsolateProviderPtr != null)
     {
-      builder.useV8Isolate(v8IsolatePtr);
+      builder.useV8IsolateProvider(v8IsolateProviderPtr);
     }
 
     // if preloaded subscriptions provided