Issue 5997 - Avoid including qunit files in release builds

tests/test_packagerWebExt.py

 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 import difflib
 import json
 import os
 import re
 import shutil
 import zipfile
@@ skipping 213 matching lines @@
     """Test-privatekey for signing chrome release-package."""
     return os.path.join(os.path.dirname(__file__), 'chrome_rsa.pem')
 
 
 @pytest.fixture
 def lib_files(tmpdir):
     files = packager.Files(['lib'], set())
     files['ext/a.js'] = 'require("./c.js");\nvar bar;'
     files['lib/b.js'] = 'var foo;'
     files['ext/c.js'] = 'var this_is_c;'
+    files['qunit/common.js'] = 'var qunit = {};'
+    files['qunit/tests/some_test.js'] = 'var passed = true;'
 
     tmpdir.mkdir('lib').join('b.js').write(files['lib/b.js'])
     ext_dir = tmpdir.mkdir('ext')
     ext_dir.join('a.js').write(files['ext/a.js'])
     ext_dir.join('c.js').write(files['ext/c.js'])
-
+    qunit_dir = tmpdir.mkdir('qunit')
+    qunit_dir.join('common.js').write(files['qunit/common.js'])
+    qunit_tests_dir = qunit_dir.mkdir('tests')
+    qunit_tests_dir.join('some_test.js').write(
+        files['qunit/tests/some_test.js']
+    )

[tlucas, 2017/11/08 12:08:51]

You are adding these scripts but do not use it in any assertion. Please see
below.

[kzar, 2017/11/09 15:33:16]

Well they are used since the bundle is created, but true I should probably add
some assertions to ensure they are.

     return files
 
 
 def comparable_xml(xml):
     """Create a nonambiguous representation of a given XML tree.
 
     Note that this function is not safe against ambiguous tags
     containing differently distributed children, e.g.:
 
     '<a><b><c/></b><b><d/></b></a>'
@@ skipping 52 matching lines @@
     assert 'var bar;' in libfoo
     assert 'webpack:///./ext/a.js' in libfoomap
 
     assert 'var this_is_c;' in libfoo
     assert 'webpack:///./ext/c.js' in libfoomap
 
     assert ('var foo;' in libfoo) != excluded
     assert ('webpack:///./lib/b.js' in libfoomap) != excluded
 
 
 def assert_devenv_scripts(package, prefix, devenv):

[tlucas, 2017/11/08 12:08:51]

I guess here would be the correct place to assert for your introduced scripts.

[kzar, 2017/11/09 15:33:16]

Done.

     manifest = json.loads(package.read(os.path.join(prefix, 'manifest.json')))
     filenames = package.namelist()
     scripts = [
         'ext/common.js',
         'ext/background.js',
     ]
 
     assert (os.path.join(prefix, 'qunit/index.html') in filenames) == devenv
     assert (os.path.join(prefix, 'devenvPoller__.js') in filenames) == devenv
     assert (os.path.join(prefix, 'devenvVersion__') in filenames) == devenv
@@ skipping 153 matching lines @@
             expected = os.path.join(
                 os.path.dirname(__file__),
                 'expecteddata',
                 filename.format(name, ext),
             )
 
             assert_manifest_content(
                 package.read(os.path.join(folder, '{}.{}'.format(name, ext))),
                 expected,
             )