Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: packagerEdge.py

Issue 29600577: Issue 5997 - Avoid including qunit files in release builds (Closed)
Left Patch Set: Created Nov. 7, 2017, 3:24 p.m.
Right Patch Set: Add assertions for qunit bundle Created Nov. 9, 2017, 3:32 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « packagerChrome.py ('k') | templates/testIndex.html.tmpl » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 # This Source Code Form is subject to the terms of the Mozilla Public 1 # This Source Code Form is subject to the terms of the Mozilla Public
2 # License, v. 2.0. If a copy of the MPL was not distributed with this 2 # License, v. 2.0. If a copy of the MPL was not distributed with this
3 # file, You can obtain one at http://mozilla.org/MPL/2.0/. 3 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
4 4
5 import base64 5 import base64
6 import hashlib 6 import hashlib
7 import json 7 import json
8 import mimetypes 8 import mimetypes
9 import os 9 import os
10 import zipfile 10 import zipfile
(...skipping 160 matching lines...) Expand 10 before | Expand all | Expand 10 after
171 packagerChrome.getIgnoredFiles(params)) 171 packagerChrome.getIgnoredFiles(params))
172 172
173 if metadata.has_section('mapping'): 173 if metadata.has_section('mapping'):
174 mapped = metadata.items('mapping') 174 mapped = metadata.items('mapping')
175 files.readMappedFiles(mapped) 175 files.readMappedFiles(mapped)
176 files.read(baseDir, skip=[filename for filename, _ in mapped]) 176 files.read(baseDir, skip=[filename for filename, _ in mapped])
177 else: 177 else:
178 files.read(baseDir) 178 files.read(baseDir)
179 179
180 if metadata.has_section('bundles'): 180 if metadata.has_section('bundles'):
181 packagerChrome.create_bundles(params, files, devenv) 181 bundle_tests = devenv and metadata.has_option('general', 'testScripts')
182 packagerChrome.create_bundles(params, files, bundle_tests)
182 183
183 if metadata.has_section('preprocess'): 184 if metadata.has_section('preprocess'):
184 files.preprocess(metadata.options('preprocess'), {'needsExt': True}) 185 files.preprocess(metadata.options('preprocess'), {'needsExt': True})
185 186
186 if metadata.has_section('import_locales'): 187 if metadata.has_section('import_locales'):
187 packagerChrome.import_locales(params, files) 188 packagerChrome.import_locales(params, files)
188 189
189 files['manifest.json'] = packagerChrome.createManifest(params, files) 190 files['manifest.json'] = packagerChrome.createManifest(params, files)
190 191
191 if devenv: 192 if devenv:
192 packagerChrome.add_devenv_requirements(files, metadata, params) 193 packagerChrome.add_devenv_requirements(files, metadata, params)
193 194
194 move_files_to_extension(files) 195 move_files_to_extension(files)
195 196
196 if metadata.has_section('appx_assets'): 197 if metadata.has_section('appx_assets'):
197 for name, path in metadata.items('appx_assets'): 198 for name, path in metadata.items('appx_assets'):
198 path = os.path.join(baseDir, path) 199 path = os.path.join(baseDir, path)
199 files.read(path, '{}/{}'.format(ASSETS_DIR, name)) 200 files.read(path, '{}/{}'.format(ASSETS_DIR, name))
200 201
201 files[MANIFEST] = create_appx_manifest(params, files, 202 files[MANIFEST] = create_appx_manifest(params, files,
202 buildNum, releaseBuild) 203 buildNum, releaseBuild)
203 files[BLOCKMAP] = create_appx_blockmap(files) 204 files[BLOCKMAP] = create_appx_blockmap(files)
204 files[CONTENT_TYPES] = create_content_types_map(files.keys() + [BLOCKMAP]) 205 files[CONTENT_TYPES] = create_content_types_map(files.keys() + [BLOCKMAP])
205 206
206 files.zip(outfile, compression=zipfile.ZIP_STORED) 207 files.zip(outfile, compression=zipfile.ZIP_STORED)
LEFTRIGHT

Powered by Google App Engine
This is Rietveld