Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29600635: Noissue - Improve error reporting for broken locale files (Closed)

Created:
Nov. 7, 2017, 6:53 p.m. by Vasily Kuznetsov
Modified:
Nov. 28, 2017, 10 a.m.
Reviewers:
mathias
CC:
juliandoucette
Visibility:
Public.

Description

Noissue - Improve error reporting for broken locale files Repository: https://hg.adblockplus.org/cms Base revision: 7348838c1e8f

Patch Set 1 #

Total comments: 3

Patch Set 2 : Add handling of missing "message" key #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -4 lines) Patch
M cms/sources.py View 1 1 chunk +21 lines, -4 lines 0 comments Download

Messages

Total messages: 5
Vasily Kuznetsov
I used this change to investigate the reason why the build of the last version ...
Nov. 7, 2017, 6:57 p.m. (2017-11-07 18:57:36 UTC) #1
juliandoucette
(Note: I downloaded and extracted the translation archive manually instead of via the CMS because ...
Nov. 7, 2017, 7:42 p.m. (2017-11-07 19:42:41 UTC) #2
mathias
https://codereview.adblockplus.org/29600635/diff/29600636/cms/sources.py File cms/sources.py (right): https://codereview.adblockplus.org/29600635/diff/29600636/cms/sources.py#newcode183 cms/sources.py:183: except (AttributeError, ValueError): What about the KeyError when 'message' ...
Nov. 7, 2017, 8:13 p.m. (2017-11-07 20:13:30 UTC) #3
Vasily Kuznetsov
Hey Matze, I finally got back to this review. Thanks for the suggestion -- it's ...
Nov. 27, 2017, 6:35 p.m. (2017-11-27 18:35:23 UTC) #4
mathias
Nov. 27, 2017, 8:05 p.m. (2017-11-27 20:05:09 UTC) #5
LGTM.

Powered by Google App Engine
This is Rietveld