Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: compiled/filter/ElemHideBase.h

Issue 29600641: Issue 5175 - Reject element hiding filter with empty domain names (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/
Patch Set: Created Nov. 7, 2017, 11:17 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « compiled/filter/ActiveFilter.cpp ('k') | compiled/filter/ElemHideBase.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 return DependentString(text, mSelectorStart); 52 return DependentString(text, mSelectorStart);
53 } 53 }
54 }; 54 };
55 55
56 class ElemHideBase : public ActiveFilter 56 class ElemHideBase : public ActiveFilter
57 { 57 {
58 protected: 58 protected:
59 ElemHideData mData; 59 ElemHideData mData;
60 public: 60 public:
61 static constexpr Type classType = Type::ELEMHIDEBASE; 61 static constexpr Type classType = Type::ELEMHIDEBASE;
62 explicit ElemHideBase(Type type, const String& text, const ElemHideData& data) ; 62 explicit ElemHideBase(Type type, const String& text, const ElemHideData& data,
63 static Type Parse(DependentString& text, ElemHideData& data); 63 const ParsedDomains& parsedDomains);
64 static Type Parse(DependentString& text, DependentString& error,
65 ElemHideData& data, ParsedDomains& parsedDomains);
64 66
65 const DependentString BINDINGS_EXPORTED GetSelector() const 67 const DependentString BINDINGS_EXPORTED GetSelector() const
66 { 68 {
67 return mData.GetSelector(mText); 69 return mData.GetSelector(mText);
68 } 70 }
69 71
70 OwnedString BINDINGS_EXPORTED GetSelectorDomain() const; 72 OwnedString BINDINGS_EXPORTED GetSelectorDomain() const;
71 }; 73 };
72 74
73 typedef intrusive_ptr<ElemHideBase> ElemHideBasePtr; 75 typedef intrusive_ptr<ElemHideBase> ElemHideBasePtr;
OLDNEW
« no previous file with comments | « compiled/filter/ActiveFilter.cpp ('k') | compiled/filter/ElemHideBase.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld