Side by Side Diff: compiled/filter/ElemHideBase.h
Issue 29600641:
Issue 5175 - Reject element hiding filter with empty domain names (Closed)
Base URL: https://hg.adblockplus.org/adblockpluscore/
Patch Set: Make the new test more functional
Created March 6, 2018, 7:47 p.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« compiled/filter/ActiveFilter.cpp ('k')
|
compiled/filter/ElemHideBase.cpp » ('j')
|
no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| OLD | NEW |
|---|---|
| 1 /* | 1 /* |
| 2 * This file is part of Adblock Plus <https://adblockplus.org/>, | 2 * This file is part of Adblock Plus <https://adblockplus.org/>, |
| 3 * Copyright (C) 2006-present eyeo GmbH | 3 * Copyright (C) 2006-present eyeo GmbH |
| 4 * | 4 * |
| 5 * Adblock Plus is free software: you can redistribute it and/or modify | 5 * Adblock Plus is free software: you can redistribute it and/or modify |
| 6 * it under the terms of the GNU General Public License version 3 as | 6 * it under the terms of the GNU General Public License version 3 as |
| 7 * published by the Free Software Foundation. | 7 * published by the Free Software Foundation. |
| 8 * | 8 * |
| 9 * Adblock Plus is distributed in the hope that it will be useful, | 9 * Adblock Plus is distributed in the hope that it will be useful, |
| 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of | 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of |
| (...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 55 return DependentString(text, mSelectorStart); | 55 return DependentString(text, mSelectorStart); |
| 56 } | 56 } |
| 57 }; | 57 }; |
| 58 | 58 |
| 59 class ElemHideBase : public ActiveFilter | 59 class ElemHideBase : public ActiveFilter |
| 60 { | 60 { |
| 61 protected: | 61 protected: |
| 62 ElemHideData mData; | 62 ElemHideData mData; |
| 63 public: | 63 public: |
| 64 static constexpr Type classType = Type::ELEMHIDEBASE; | 64 static constexpr Type classType = Type::ELEMHIDEBASE; |
| 65 explicit ElemHideBase(Type type, const String& text, const ElemHideData& data) ; | 65 explicit ElemHideBase(Type type, const String& text, const ElemHideData& data, |
| 66 static Type Parse(DependentString& text, ElemHideData& data, bool& needConvers ion); | 66 const ParsedDomains& parsedDomains); |
| 67 static Type Parse(DependentString& text, DependentString& error, | |
| 68 ElemHideData& data, bool& needConversion, ParsedDomains& parsedDomains); | |
| 67 static DependentString ConvertFilter(String& text, String::size_type& at); | 69 static DependentString ConvertFilter(String& text, String::size_type& at); |
| 68 | 70 |
| 69 OwnedString BINDINGS_EXPORTED GetSelector() const; | 71 OwnedString BINDINGS_EXPORTED GetSelector() const; |
| 70 OwnedString BINDINGS_EXPORTED GetSelectorDomain() const; | 72 OwnedString BINDINGS_EXPORTED GetSelectorDomain() const; |
| 71 }; | 73 }; |
| 72 | 74 |
| 73 typedef intrusive_ptr<ElemHideBase> ElemHideBasePtr; | 75 typedef intrusive_ptr<ElemHideBase> ElemHideBasePtr; |
| 74 | 76 |
| 75 ABP_NS_END | 77 ABP_NS_END |
| OLD | NEW |
« no previous file with comments
|
« compiled/filter/ActiveFilter.cpp ('k')
|
compiled/filter/ElemHideBase.cpp » ('j')
|
no next file with comments »
