compiled/filter/ElemHideFilter.h - Issue 29600641: Issue 5175 - Reject element hiding filter with empty domain names

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: compiled/filter/ElemHideFilter.h

Issue 29600641: Issue 5175 - Reject element hiding filter with empty domain names (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/

Patch Set: Make the new test more functional Created March 6, 2018, 7:47 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * This file is part of Adblock Plus <https://adblockplus.org/>,	2 * This file is part of Adblock Plus <https://adblockplus.org/>,

3 * Copyright (C) 2006-present eyeo GmbH	3 * Copyright (C) 2006-present eyeo GmbH

4 *	4 *

5 * Adblock Plus is free software: you can redistribute it and/or modify	5 * Adblock Plus is free software: you can redistribute it and/or modify

6 * it under the terms of the GNU General Public License version 3 as	6 * it under the terms of the GNU General Public License version 3 as

7 * published by the Free Software Foundation.	7 * published by the Free Software Foundation.

8 *	8 *

9 * Adblock Plus is distributed in the hope that it will be useful,	9 * Adblock Plus is distributed in the hope that it will be useful,

10 * but WITHOUT ANY WARRANTY; without even the implied warranty of	10 * but WITHOUT ANY WARRANTY; without even the implied warranty of

(...skipping 11 matching lines...) Expand all Loading...
22 #include "../base.h"	22 #include "../base.h"

23 #include "Filter.h"	23 #include "Filter.h"

24 #include "ElemHideBase.h"	24 #include "ElemHideBase.h"

25	25

26 ABP_NS_BEGIN	26 ABP_NS_BEGIN

27	27

28 class ElemHideFilter: public ElemHideBase	28 class ElemHideFilter: public ElemHideBase

29 {	29 {

30 public:	30 public:

31 static constexpr Type classType = Type::ELEMHIDE;	31 static constexpr Type classType = Type::ELEMHIDE;

32 explicit ElemHideFilter(const String& text, const ElemHideData& data);	32 explicit ElemHideFilter(const String& text, const ElemHideData& data,

	33 const ParsedDomains& parsedDomains);

33 };	34 };

34	35

35 typedef intrusive_ptr<ElemHideFilter> ElemHideFilterPtr;	36 typedef intrusive_ptr<ElemHideFilter> ElemHideFilterPtr;

36	37

37 ABP_NS_END	38 ABP_NS_END

OLD	NEW

« no previous file with comments | « compiled/filter/ElemHideException.cpp ('k') | compiled/filter/ElemHideFilter.cpp » ('j') | no next file with comments »