Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: compiled/filter/ActiveFilter.cpp

Issue 29600641: Issue 5175 - Reject element hiding filter with empty domain names (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/
Left Patch Set: Rebased Created Dec. 5, 2017, 6:06 p.m.
Right Patch Set: Make the new test more functional Created March 6, 2018, 7:47 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « compiled/filter/ActiveFilter.h ('k') | compiled/filter/ElemHideBase.h » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details. 12 * GNU General Public License for more details.
13 * 13 *
14 * You should have received a copy of the GNU General Public License 14 * You should have received a copy of the GNU General Public License
15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. 15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
16 */ 16 */
17 17
18 #include <cstdio> 18 #include <cstdio>
19 19
20 #include "ActiveFilter.h" 20 #include "ActiveFilter.h"
21 #include "../StringScanner.h" 21 #include "../StringScanner.h"
22 22
23 namespace 23 ABP_NS_USING
24 { 24
25 const DependentString DEFAULT_DOMAIN(u""_str); 25 const DependentString ActiveFilter::DEFAULT_DOMAIN(u""_str);
26 }
27 26
28 ActiveFilter::ActiveFilter(Type type, const String& text, bool ignoreTrailingDot ) 27 ActiveFilter::ActiveFilter(Type type, const String& text, bool ignoreTrailingDot )
29 : Filter(type, text), mIgnoreTrailingDot(ignoreTrailingDot), 28 : Filter(type, text), mIgnoreTrailingDot(ignoreTrailingDot),
30 mDisabled(false), mHitCount(0), mLastHit(0) 29 mDisabled(false), mHitCount(0), mLastHit(0)
31 { 30 {
32 } 31 }
33 32
34 ActiveFilter::DomainMap* ActiveFilter::GetDomains() const 33 ActiveFilter::DomainMap* ActiveFilter::GetDomains() const
35 { 34 {
36 return mDomains.get(); 35 return mDomains.get();
(...skipping 174 matching lines...) Expand 10 before | Expand all | Expand 10 after
211 result.append(u'\n'); 210 result.append(u'\n');
212 } 211 }
213 if (mLastHit) 212 if (mLastHit)
214 { 213 {
215 result.append(u"lastHit="_str); 214 result.append(u"lastHit="_str);
216 result.append(mLastHit); 215 result.append(mLastHit);
217 result.append(u'\n'); 216 result.append(u'\n');
218 } 217 }
219 return result; 218 return result;
220 } 219 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld