Issue 5872 - apply style changes

skin/desktop-options.css

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 31 matching lines @@
   src: local("Ø"), url(fonts/SourceSansPro-bold.woff) format("woff");
   font-weight: 700;
   font-style: normal;
 }
 
 html
 {
   font-size: 16px;
 }
 
 body

[ire, 2017/11/09 09:08:29]

The line-height isn't set at all? It's supposed to be 1.5

[saroyanm, 2017/11/13 17:07:14]

Yes, it's not, the style guide are being constantly updated.
Done.

 {
   background-color: #F3F3F3;
   display: flex;
   justify-content: center;
   /* We force vertical scrollbars to keep the content centered */
   overflow-y: scroll;
-  margin: 1.2rem 0.3rem;
+  margin: 1rem 0.3rem;
   font-family: "Source Sans Pro", sans-serif;
   font-size: 1rem;
-  color: #494949;

[ire, 2017/11/09 09:08:28]

According to the spec this colour should be #4A4A4A?

[saroyanm, 2017/11/13 17:07:14]

Well spotted, done.

+  line-height: 1.5rem;
+  color: #4A4A4A;
 }
 
 h1
 {
   font-size: 3rem;
   font-weight: 300;
+  line-height: 3rem;
 }
 
 h2
 {
   font-size: 1.125rem;
   font-weight: 700;
 }
 
 a
 {
   color: #077CA6;
-  text-decoration: none;

[ire, 2017/11/09 09:08:28]

Shouldn't this be underlined?

[saroyanm, 2017/11/13 17:07:14]

Well spotted, seems like I missed when this was updated.
Done.

 }
 
 a:hover
 {
   color: #5CBCE1;
 }
 
 ul
 {
   margin: 0rem;
 }
 
 [aria-hidden="true"]
 {
   display: none !important;
 }
 
 input[type="text"],
 input[type="url"],
 textarea,
 main
 {
   -webkit-box-sizing: border-box;
   -moz-box-sizing: border-box;
   box-sizing: border-box;
+}
+
+/*
+  Normalization
+ */
+
+input,
+button
+{
+  font-family: inherit;
+}
+
+button
+{
+  border-radius: 0rem;
 }
 
 /*
   Buttons and links
  */
 
 button,
 .button

[ire, 2017/11/09 09:08:28]

Since Chrome 62, buttons by default have rounded corners so you would need to
set `border-radius: 0`

[saroyanm, 2017/11/13 17:07:14]

Interesting, didn't know about that, apparently that affects only Mac users.
Updated.

 {
   display: block;
   padding: 0.6rem 0.8rem;
   background-color: transparent;
   font-size: 1rem;
   font-weight: 700;
   text-decoration: none;
   text-transform: uppercase;
   cursor: pointer;
 }
@@ skipping 68 matching lines @@
 }
 
 button[role="checkbox"][aria-checked="true"].toggle
 {
   background: url(icons/toggle.svg#on);
 }
 
 button[role="checkbox"].toggle
 {
   background-position: initial;
-  width: 1.7rem;

[ire, 2017/11/09 09:08:29]

This should be 1.9rem according to the spec
(https://bitbucket.org/adblockplus/spec/src/b140349a623ca03a314b03009cecbff948...)

[saroyanm, 2017/11/13 17:07:14]

You are right, the SVG should have been updated first, because in Firefox it was
clear that proportions was wrong, now it should be right dimensions.
Done.

+  width: 1.9rem;
   height: 1rem;
+  vertical-align: middle;
 }
 
 button[role="checkbox"][disabled].toggle
 {
   background-image: none;
 }
 
 button.delete::before
 {
   background-image: url(icons/trash.svg#default);
@@ skipping 22 matching lines @@
   background-color: transparent;
 }
 
 button.gear::before,
 button.delete::before
 {
   content: "";
   display: block;
   height: 1rem;
   width: 1rem;
   border: 0.2rem solid transparent;

[ire, 2017/11/09 09:08:28]

I don't understand the purpose of the border, could you please explain?

I also discovered that it was causing extra spacing in the .context-menu icon

[saroyanm, 2017/11/13 17:07:15]

I think I should have left a comment here:
There was a question whether the 1rem is small enough or not, Jeen asked me to
leave the icons size 1rem, but increase the hover(click) area, see ->
https://bitbucket.org/adblockplus/spec/pull-requests/84/issue-89-adjusted-fon...

It mentioned Padding there, but intention is to have broader clickable zone.

[ire, 2017/11/14 16:55:20]

Okay I understand now, thanks!

The issue in the .context-menu still exists though. Perhaps you should add this
border only to the icon in the table, so it doesn't interfere with that other
use case?

[saroyanm, 2017/11/14 19:19:00]

Right, I missed the part about the .context-menu
.context-menu is also in the table and we are using delete icons in different
tables as well, I think we should have a rule for context-menu which will
override this.
Done.

   background-repeat: no-repeat;
   background-position: center;
 }
 
 button.link,
 button.list
 {
   color: #077CA6;
 }
 
 button.link

[ire, 2017/11/14 16:55:21]

This should be underlined to look like the <a> links

[saroyanm, 2017/11/14 19:18:59]

I agree, done.

 {
   border: 0px;
   background-color: transparent;
-  font-weight: 300;
+  font-weight: 400;
   font-family: inherit;
   text-transform: none;
+  text-decoration: underline;
   padding: 0.2rem;
 }
 
 button.link:hover
 {
   color: #5CBCE1;
 }
 
 button.list
 {
   border-style: solid;;
   border-color: #CDCDCD;
-  border-width: 0px 1px 1px 1px;
+  border-width: 1px;
   width: 100%;
   background-color: #E1F2FA;
   text-align: initial;
 }
 
 button.list:hover
 {
   box-shadow: inset 0 0 0 3px #077CA6;
   border-color: #077CA6;
 }
@@ skipping 28 matching lines @@
   position: relative;
   padding-top: 0.7rem;
   margin: 1.8rem 0rem 0.5rem 0rem;
 }
 
 .floating-input input
 {
   border-color: #CDCDCD;
   border-width: 0px 0px 1px 0px;
   outline: none;
-  font-size: 1.3rem;
+  font-size: 1rem;
   padding: 5px;
   width: 100%;
 }
 
 .floating-input input:placeholder-shown ~ label,
 .floating-input input + label,
 .floating-input input:focus + label
 {
   position: absolute;
   top: 0.9rem;
   left: 0.3rem;
-  font-size: 1.3rem;
+  font-size: 1rem;
 }
 
 .floating-input input + label,
 .floating-input input:focus + label
 {
   top: -0.5rem;
   font-size: 0.9rem;
 }
 
 html[dir="rtl"] .floating-input input:placeholder-shown ~ label,
@@ skipping 12 matching lines @@
 [data-validation] .floating-input input:focus:invalid ~ .attention::before,
 [data-validation] .floating-input input:valid ~ .attention::before
 {
   content: "";
   position: absolute;
   display: block;
   margin: 0.5rem;
   height: 1.5rem;
   width: 1.5rem;
   border: 0rem;
-  top: 0.5rem;
+  top: 0.3rem;
   right: 0rem;
 }
 
 html[dir="rtl"] [data-validation] .floating-input input:focus:invalid ~ .attention::before,
 html[dir="rtl"] [data-validation] .floating-input input:valid ~ .attention::before
 {
   left: 0rem;
   right: auto;
 }
 
 [data-validation] .floating-input input:focus:invalid ~ .attention::before
 {
   background-image: url(icons/attention.svg);
 }
 
 [data-validation] .floating-input input:valid ~ .attention::before
 {
-  top: 0.8rem;
+  top: 0.5rem;
   background-image: url(icons/checkmark.svg#approved);
 }
 
 [data-validation] .floating-input input ~ .error-msg
 {
   margin-top: 0.5rem;
   color: #C11D27;
   display: block;
   visibility: hidden;
 }
@@ skipping 45 matching lines @@
 
 #sidebar header h1 strong
 {
   font-weight: 700;
 }
 
 #sidebar header p
 {
   margin: 0rem;
   font-size: 2.4rem;
+  line-height: 2.6rem;
 }
 
 html[dir="rtl"] #sidebar header
 {
   text-align: left;
 }
 
 #sidebar-logo
 {
   width: 3rem;
@@ skipping 48 matching lines @@
 
 #sidebar footer
 {
   width: 100%;
 }
 
 #sidebar footer p
 {
   display: flex;
   justify-content: center;
-  margin: 1.2rem 0rem;

[ire, 2017/11/14 16:55:21]

The vertical spacing here should be 1rem

[saroyanm, 2017/11/14 19:19:00]

Well spotted, done.

+  margin: 1rem 0rem;
 }
 
 /* This is a stopgap solution of footer overlapping tabs on low resolutions */
 @media (min-height: 37rem)
 {
   #sidebar .fixed
   {
     position: fixed;
   }
 
@@ skipping 13 matching lines @@
 body[data-tab|="whitelist"] #content-whitelist,
 body[data-tab|="help"] #content-help
 {
   display: block;
 }
 
 main
 {
   background-color: #FFFFFF;
   border: 1px solid #CDCDCD;
   width: 46.3rem;

[ire, 2017/11/09 09:08:29]

I think your intention was to force this element to always be 46.3rem and never
resize, but it still does. If that was your intention, you also need to add
`min-width: 46.3rem`

[saroyanm, 2017/11/13 17:07:15]

My intention was to prevent a main area resize effect, switching from/to
Whitelisting website were causing an annoying resize effect

[ire, 2017/11/14 16:55:20]

Acknowledged.

   padding: 0px 0rem 1.4rem 0rem;
 }
 
 main > div
 {
   display: none;
 }
 
 main p
 {
   margin: 0.8rem 0rem;
 }
 
 /*
   Sections
  */
 
 [role="tabpanel"] > section,
 [role="tabpanel"] > .section
 {
-  padding: 2rem;

[ire, 2017/11/14 16:55:21]

According to the spec this spacing should be 1.4rem

[saroyanm, 2017/11/14 19:18:59]

You are right, vertical spacings seems to be specified as 1.4rem, but horizontal
looks to still be 2rem. 
Done.

+  padding: 1.4rem 2rem;
   border-top: 1px solid #CDCDCD;
 }
 
 [role="tabpanel"] > header h1,
 [role="tabpanel"] > header p
 {
   padding: 0rem 2rem;
   margin: 1.4rem 0rem;
 }
 
@@ skipping 110 matching lines @@
 {
   margin: 0rem;
   border-style: solid;
   border-color: #CDCDCD;
   border-width: 0px 1px 1px 1px;
 }
 
 .list li
 {
   padding: 0rem;
-  margin: 0rem 0rem 0.8rem 0rem;

[ire, 2017/11/09 09:08:28]

I don't think you need to apply margins to all of the sides here.
`margin-bottom: 0.8rem` works the same.

[saroyanm, 2017/11/13 17:07:14]

Agree, done.

+  margin-bottom: 0.8rem;
 }
 
 .list li [role="checkbox"]
 {
   flex-shrink: 0;
 }
 
 .table li:first-of-type
 {
   border-top: 1px solid #CDCDCD;
 }
 
 .table.list li
 {
-  padding: 0.5rem 1.0rem;

[ire, 2017/11/09 09:08:28]

You don't need the .0 here. i.e 1rem is enough

[saroyanm, 2017/11/13 17:07:15]

Done.

-  margin: 0rem;
+  padding: 0.5rem 1rem;
+  margin: 0rem;
+}
+
+.table.list.bottom-control li:last-of-type
+{
+  border-bottom: 0px;
 }
 
 li .display
 {
   margin: 0rem 1rem;
 }
 
 .table.list li .display
 {
   flex: 1;
   margin: 0rem;
 }
 
 .table.list li.empty-placeholder
 {
-  padding: 1.3em 1.9em;
+  padding: 1rem 1.4rem;
 }
 
 .table.list li.empty-placeholder:not(:last-of-type)
 {
   border-bottom: 0px;
-}
-
-#blocking-languages-table .display
-{
-  font-weight: 700;
 }
 
 .table.list button.link
 {
   font-weight: 700;
   text-transform: uppercase;
+  text-decoration: none;
 }
 
 .table:not(.list):not(.cols) li
 {
   padding-top: 0px;
   padding-bottom: 6px;
 }
 
 .table li [data-single="visible"],
 .table li:first-of-type:last-of-type [data-single="hidden"]
@@ skipping 17 matching lines @@
 }
 
 .col5
 {
   margin: 0rem 1rem;
 }
 
 .th .col5:nth-of-type(1),
 .table .col5:nth-of-type(1)
 {
-  flex: 7;

[ire, 2017/11/09 09:08:28]

NIT: It's not exactly clear how these flex numbers came about.

Suggestions:

1. The last two columns should be the same size (`flex: 1`)
2. The first and fourth columns should be 4 times the base size (`flex: 4`)
3. The second column, like you did, is double the first column (`flex: 8`)

[saroyanm, 2017/11/13 17:07:15]

Mostly eyepick
I agree with you.

+  flex: 4;
 }
 
 .th .col5:nth-of-type(2),
 .table .col5:nth-of-type(2)
 {
-  flex: 14;
+  flex: 8;
 }
 
 .th .col5:nth-of-type(3),
 .table .col5:nth-of-type(3)
 {
-  flex: 7;
+  flex: 4;
 }
 
 .th .col5:nth-of-type(4),
 .table .col5:nth-of-type(4)
 {
-  flex: 2;
+  flex: 1;
 }
 
 .th .col5:nth-of-type(5),
 .table .col5:nth-of-type(5)
 {
   flex: 1;
   -moz-margin-start: 0;
   -webkit-margin-start: 0;
   -moz-margin-end: 1.8rem;
   -webkit-margin-end: 1.8rem;
 }
 
-.table.cols
-{
-  font-size: 1rem;

[ire, 2017/11/09 09:08:29]

I don't think setting the font-size is necessary here, the body font-size is
inherited

[saroyanm, 2017/11/13 17:07:14]

Done.

-}
-
 .table.cols .display
 {
   margin: 0rem;
 }
 
 .table.cols li
 {
   padding: 0.9rem 0rem;
 }
 
@@ skipping 47 matching lines @@
   height: 1.3rem;
   background-image: url(icons/checkmark.svg#default);
   margin: 0rem;
 }
 
 #dialog .table.list li button .display
 {
   flex: none;
   margin: 0rem 0.8rem;
   text-transform: none;
+  font-weight: 400;
 }
 
 /*
   Tooltips
 */
 
 .tooltip
 {
   display: inline-block;
   position: relative;
@@ skipping 49 matching lines @@
 
 /*
   Whitelist tab
  */
 
 #content-whitelist form
 {
   display: flex;
 }
 
 #content-whitelist form input

[ire, 2017/11/09 09:08:29]

The font-family for this input isn't the "Source Sans Pro", it's the default
system font

[saroyanm, 2017/11/13 17:07:15]

Well spotted!
Done.

 {
   flex: 1;
   height: 100%;
   padding: 0.5rem 1rem;
   font-size: 1rem;
   border: 2px solid #077CA6;
 }
 
 #content-whitelist form button
 {
   -moz-margin-start: 0.7rem;
   -webkit-margin-start: 0.7rem;
 }
 
 #whitelisting-table li
 {
+  padding-left: 1.4rem;
+  padding-right: 1.4rem;
   border-left: 0rem;
   border-right: 0rem; 
 }
 
 /*
   Advanced tab content
 */
 
 #all-filter-lists-table li.show-message .last-update,
 #all-filter-lists-table li:not(.show-message) .message,
@@ skipping 53 matching lines @@
 li [role="menubar"]
 {
   position: relative;
 }
 
 [role="tooltip"]
 {
   right: -1rem;
   margin-top: 1rem;
   opacity: 1;
-  padding: 1.3rem;
+  padding: 0.2rem 1rem;
   position: absolute;
   -webkit-transition: opacity 200ms ease-in-out 400ms,
     visibility 0ms linear 400ms;
   transition: opacity 200ms ease-in-out 400ms,
     visibility 0ms linear 400ms;
   visibility: visible;
   width: 15rem;
   z-index: 1;
 }
 
@@ skipping 96 matching lines @@
   padding: 0rem;
 }
 
 .context-menu li[role="menuitem"] > *
 {
   width: 100%;
   display: flex;
   border: 0rem;
   padding: 0.7rem 0rem;
   color: #077CA6;
+  align-items: center;
   font-size: 1rem;

[saroyanm, 2017/11/08 15:46:46]

Note: There is a difference between font-sizes for buttons and <a> tags in this
context menu, I'm not sure if there is an easy fix?
This needs an investigation, if it's not easy fixable make sense to tackle
separately.

[ire, 2017/11/09 09:08:29]

It's because the font families aren't actually the same. I think you need to set
`font-family: "Source Sans Pro"` here

[saroyanm, 2017/11/13 17:07:14]

Right, Done :)

-  font-weight: 700;
+  font-weight: 400;
   text-transform: none;
+  text-decoration: none;
 }
 
 .context-menu li[role="menuitem"] > *:hover,
 .context-menu li[role="menuitem"] > *:focus
 {
   background-color: #E1F2FA;
   cursor: pointer;
 }
 
 .context-menu li[role="menuitem"] > *::before
 {
   content: "";
   height: 1rem;
   width: 1rem;
   margin: 0rem 1.1rem;
+  border: 0rem;
 }
 
 .context-menu .update-subscription::before
 {
   background-image: url(icons/reload.svg);
 }
 
 .context-menu .website::before
 {
   background-image: url(icons/globe.svg);
@@ skipping 29 matching lines @@
 {
   display: inline-block;
   -moz-margin-end: 1rem;
   -webkit-margin-end: 1rem;
 }
 
 #social ul li a
 {
   display: block;
   text-align: center;
+  text-decoration: none;
 }
 
 #social ul li a::before
 {
   display: block;
   margin: 0em auto;
   width: 2.5rem;
   height: 2.5rem;
   content: "";
 }
@@ skipping 111 matching lines @@
 }
 
 [data-dialog="about"] button
 {
   margin: 1.5rem auto 1.8rem auto;
 }
 
 [data-dialog="about"] p
 {
   margin: 0.5rem 0rem;
-}
-
-#abp-version
-{
-  margin-bottom: 2rem;
 }
 
 [data-dialog="import"] .side-controls
 {
   margin-top: 2.45rem;
 }
 
 #dialog .table
 {
   width: 100%;
@@ skipping 71 matching lines @@
 
 #hide-notification::after
 {
   background-image: url(icons/delete.svg#secondary);
 }
 
 #hide-notification:hover::after
 {
   background-image: url(icons/delete.svg#secondary-hover);
 }