Delta Between Two Patch Sets: desktop-options.html
Issue 29601581:
Issue 5872 - apply style changes (Closed)
Left Patch Set: Addressed Ire's comments
Created Nov. 13, 2017, 5:05 p.m.
Right Patch Set:
Created Nov. 15, 2017, 2:50 p.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with change/comment
|
« no previous file
|
skin/desktop-options.css » ('j')
|
no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| LEFT | RIGHT |
|---|---|
| 1 <!DOCTYPE html> | 1 <!DOCTYPE html> |
| 2 <!-- | 2 <!-- |
| 3 - This file is part of Adblock Plus <https://adblockplus.org/>, | 3 - This file is part of Adblock Plus <https://adblockplus.org/>, |
| 4 - Copyright (C) 2006-present eyeo GmbH | 4 - Copyright (C) 2006-present eyeo GmbH |
| 5 - | 5 - |
| 6 - Adblock Plus is free software: you can redistribute it and/or modify | 6 - Adblock Plus is free software: you can redistribute it and/or modify |
| 7 - it under the terms of the GNU General Public License version 3 as | 7 - it under the terms of the GNU General Public License version 3 as |
| 8 - published by the Free Software Foundation. | 8 - published by the Free Software Foundation. |
| 9 - | 9 - |
| 10 - Adblock Plus is distributed in the hope that it will be useful, | 10 - Adblock Plus is distributed in the hope that it will be useful, |
| (...skipping 105 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 116 </ul> | 116 </ul> |
| 117 </ul> | 117 </ul> |
| 118 </form> | 118 </form> |
| 119 </section> | 119 </section> |
| 120 <section class="cols"> | 120 <section class="cols"> |
| 121 <header> | 121 <header> |
| 122 <h2 class="i18n_options_language_header"></h2> | 122 <h2 class="i18n_options_language_header"></h2> |
| 123 <p class="i18n_options_language_description"></p> | 123 <p class="i18n_options_language_description"></p> |
| 124 </header> | 124 </header> |
| 125 <div id="blocking-languages"> | 125 <div id="blocking-languages"> |
| 126 <ul id="blocking-languages-table" class="table list"> | 126 <ul id="blocking-languages-table" class="table list bottom-control"> |
| 127 <template> | 127 <template> |
| 128 <label class="display"></label> | 128 <label class="display"></label> |
| 129 <button data-single="hidden" data-action="remove-subscription" c lass="delete control" title="options_control_remove_title"></button> | 129 <button data-single="hidden" data-action="remove-subscription" c lass="delete control" title="options_control_remove_title"></button> |
| 130 <button data-single="visible" data-action="open-dialog" data-dia log="language-change" class="i18n_options_language_change link"></button> | 130 <button data-single="visible" data-action="open-dialog" data-dia log="language-change" class="i18n_options_language_change link"></button> |
| 131 </template> | 131 </template> |
| 132 </ul> | 132 </ul> |
| 133 <button class="i18n_options_language_add list" data-action="open-dia log" data-dialog="language-add"></button> | 133 <button class="i18n_options_language_add list" data-action="open-dia log" data-dialog="language-add"></button> |
| 134 <p class="i18n_options_language_tip"></p> | 134 <p class="i18n_options_language_tip"></p> |
| 135 </div> | 135 </div> |
| 136 </section> | 136 </section> |
| (...skipping 177 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 314 <li id="visit-forum" class="i18n_options_report_forum"></li> | 314 <li id="visit-forum" class="i18n_options_report_forum"></li> |
| 315 </ul> | 315 </ul> |
| 316 </section> | 316 </section> |
| 317 <section class="cols"> | 317 <section class="cols"> |
| 318 <header> | 318 <header> |
| 319 <h2 class="i18n_options_social_title"></h2> | 319 <h2 class="i18n_options_social_title"></h2> |
| 320 <p class="i18n_options_social_description"></p> | 320 <p class="i18n_options_social_description"></p> |
| 321 </header> | 321 </header> |
| 322 <div id="social"> | 322 <div id="social"> |
| 323 <ul id="social-general"> | 323 <ul id="social-general"> |
| 324 <li><a id="twitter" target="_blank">Twitter</a></li> | 324 <li><a id="twitter" target="_blank">Twitter</a></li> |
|
ire
2017/11/14 16:55:21
These links are now also underlined. It's not clea
saroyanm
2017/11/14 19:19:00
Yes, I've removed them, will introduce them back i
| |
| 325 <li><a id="facebook" target="_blank">Facebook</a></li> | 325 <li><a id="facebook" target="_blank">Facebook</a></li> |
| 326 <li><a id="google-plus" target="_blank">Google Plus</a></li> | 326 <li><a id="google-plus" target="_blank">Google Plus</a></li> |
| 327 </ul> | 327 </ul> |
| 328 <ul id="social-chinese"> | 328 <ul id="social-chinese"> |
| 329 <li><a id="weibo" target="_blank">Weibo</a></li> | 329 <li><a id="weibo" target="_blank">Weibo</a></li> |
| 330 </ul> | 330 </ul> |
| 331 <p> | 331 <p> |
| 332 <strong> | 332 <strong> |
| 333 <span class="i18n_options_email"></span> | 333 <span class="i18n_options_email"></span> |
| 334 <a href="mailto:support@adblockplus.org">support@adblockplus.org </a> | 334 <a href="mailto:support@adblockplus.org">support@adblockplus.org </a> |
| (...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 409 </div> | 409 </div> |
| 410 <!-- Notification --> | 410 <!-- Notification --> |
| 411 <div id="notification" aria-hidden="true" aria-live="polite"> | 411 <div id="notification" aria-hidden="true" aria-live="polite"> |
| 412 <strong id="notification-text"></strong> | 412 <strong id="notification-text"></strong> |
| 413 <button id="hide-notification" data-action="hide-notification"> | 413 <button id="hide-notification" data-action="hide-notification"> |
| 414 <span class="i18n_options_notification_hide sr-only"></span> | 414 <span class="i18n_options_notification_hide sr-only"></span> |
| 415 </button> | 415 </button> |
| 416 </div> | 416 </div> |
| 417 </body> | 417 </body> |
| 418 </html> | 418 </html> |
| LEFT | RIGHT |
« no previous file
|
skin/desktop-options.css » ('j')
|
Toggle Intra-line Diffs ('i')
|
Expand Comments ('e')
|
Collapse Comments ('c')
|
Toggle Comments ('s')
