Issue 5872 - apply style changes

skin/desktop-options.css

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 38 matching lines @@
   font-size: 16px;
 }
 
 body
 {
   background-color: #F3F3F3;
   display: flex;
   justify-content: center;
   /* We force vertical scrollbars to keep the content centered */
   overflow-y: scroll;
-  margin: 1.2rem 0.3rem;

[ire, 2017/11/15 13:49:28]

The vertical margin should be 1rem

[saroyanm, 2017/11/15 14:51:23]

Done.

+  margin: 1rem 0.3rem;
   font-family: "Source Sans Pro", sans-serif;
   font-size: 1rem;
   line-height: 1.5rem;
   color: #4A4A4A;
 }
 
 h1
 {
   font-size: 3rem;
   font-weight: 300;
@@ skipping 299 matching lines @@
   right: 0.3rem;
   left: auto;
 }
 
 [data-validation] .floating-input input:focus:invalid
 {
   border-color: #C11D27;
 }
 
 [data-validation] .floating-input input:focus:invalid ~ .attention::before,
 [data-validation] .floating-input input:valid ~ .attention::before

[ire, 2017/11/15 13:49:28]

This element is too close to the input underline. There should be more space
between the two

[saroyanm, 2017/11/15 14:51:23]

Done.

 {
   content: "";
   position: absolute;
   display: block;
   margin: 0.5rem;
   height: 1.5rem;
   width: 1.5rem;
   border: 0rem;
-  top: 0.5rem;
+  top: 0.3rem;
   right: 0rem;
 }
 
 html[dir="rtl"] [data-validation] .floating-input input:focus:invalid ~ .attention::before,
 html[dir="rtl"] [data-validation] .floating-input input:valid ~ .attention::before
 {
   left: 0rem;
   right: auto;
 }
 
 [data-validation] .floating-input input:focus:invalid ~ .attention::before
 {
   background-image: url(icons/attention.svg);
 }
 
 [data-validation] .floating-input input:valid ~ .attention::before
 {
-  top: 0.8rem;
+  top: 0.5rem;
   background-image: url(icons/checkmark.svg#approved);
 }
 
 [data-validation] .floating-input input ~ .error-msg
 {
   margin-top: 0.5rem;
   color: #C11D27;
   display: block;
   visibility: hidden;
 }
@@ skipping 337 matching lines @@
 }
 
 .table.list li .display
 {
   flex: 1;
   margin: 0rem;
 }
 
 .table.list li.empty-placeholder
 {
-  padding: 1.3em 1.9em;

[ire, 2017/11/15 13:49:28]

This padding should be the same as `padding: 0.5rem 1rem;`

[saroyanm, 2017/11/15 14:51:23]

According to specs, it's 1rem 1.4rem, I've updated accordingly (
https://bitbucket.org/adblockplus/spec/src/b140349a623ca03a314b03009cecbff948...
)

+  padding: 1rem 1.4rem;
 }
 
 .table.list li.empty-placeholder:not(:last-of-type)
 {
   border-bottom: 0px;
 }
 
 .table.list button.link
 {
   font-weight: 700;
@@ skipping 122 matching lines @@
 
 #dialog .table.list li button[aria-checked="true"]::before
 {
   content: "";
   width: 1.3rem;
   height: 1.3rem;
   background-image: url(icons/checkmark.svg#default);
   margin: 0rem;
 }
 
 #dialog .table.list li button .display

[ire, 2017/11/15 13:49:28]

This element is currently in bold weight since it's a button, but I think it
should be same as body font weight

[saroyanm, 2017/11/15 14:51:23]

Right, done.

 {
   flex: none;
   margin: 0rem 0.8rem;
   text-transform: none;
+  font-weight: 400;
 }
 
 /*
   Tooltips
 */
 
 .tooltip
 {
   display: inline-block;
   position: relative;
@@ skipping 551 matching lines @@
 
 #hide-notification::after
 {
   background-image: url(icons/delete.svg#secondary);
 }
 
 #hide-notification:hover::after
 {
   background-image: url(icons/delete.svg#secondary-hover);
 }