Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1261)

Issue 29601607: Issue 5963 - Fix alignment of product icon next to article title on help.eyeo.com (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 8 months ago by ire
Modified:
1 year, 8 months ago
Reviewers:
juliandoucette
Base URL:
https://hg.adblockplus.org/help.eyeo.com
Visibility:
Public.

Description

Issue 5963 - Fix alignment of product icon next to article title on help.eyeo.com

Patch Set 1 #

Total comments: 2

Patch Set 2 : max-width: - 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M static/scss/components/_article.scss View 1 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 4
ire
1 year, 8 months ago (2017-11-08 15:37:17 UTC) #1
juliandoucette
https://codereview.adblockplus.org/29601607/diff/29601608/static/scss/components/_article.scss File static/scss/components/_article.scss (right): https://codereview.adblockplus.org/29601607/diff/29601608/static/scss/components/_article.scss#newcode41 static/scss/components/_article.scss:41: @media (max-width: $phablet-breakpoint + 1) +1 should be -1. ...
1 year, 8 months ago (2017-11-09 14:22:30 UTC) #2
ire
https://codereview.adblockplus.org/29601607/diff/29601608/static/scss/components/_article.scss File static/scss/components/_article.scss (right): https://codereview.adblockplus.org/29601607/diff/29601608/static/scss/components/_article.scss#newcode41 static/scss/components/_article.scss:41: @media (max-width: $phablet-breakpoint + 1) On 2017/11/09 14:22:30, juliandoucette ...
1 year, 8 months ago (2017-11-10 09:44:25 UTC) #3
juliandoucette
1 year, 8 months ago (2017-11-10 10:44:51 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5