Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(83)

Issue 29602576: Issue 6015 - Give feedback is pointing to mozilla page (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 3 months ago by diegocarloslima
Modified:
2 years, 3 months ago
Reviewers:
jens, anton
CC:
René Jeschke, Felix Dahlke
Visibility:
Public.

Description

Issue 6015 - Give feedback is pointing to mozilla page

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M mobile/android/app/mobile.js View 1 chunk +2 lines, -2 lines 0 comments Download
M mobile/android/base/resources/xml/preferences_vendor.xml View 1 chunk +1 line, -2 lines 1 comment Download
M mobile/android/base/strings.xml.in View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 3
diegocarloslima
https://codereview.adblockplus.org/29602576/diff/29602577/mobile/android/base/resources/xml/preferences_vendor.xml File mobile/android/base/resources/xml/preferences_vendor.xml (right): https://codereview.adblockplus.org/29602576/diff/29602577/mobile/android/base/resources/xml/preferences_vendor.xml#newcode22 mobile/android/base/resources/xml/preferences_vendor.xml:22: android:persistent="false"/> Here, I'm simply reverting the changes that we ...
2 years, 3 months ago (2017-11-09 21:21:48 UTC) #1
anton
On 2017/11/09 21:21:48, diegocarloslima wrote: > https://codereview.adblockplus.org/29602576/diff/29602577/mobile/android/base/resources/xml/preferences_vendor.xml > File mobile/android/base/resources/xml/preferences_vendor.xml (right): > > https://codereview.adblockplus.org/29602576/diff/29602577/mobile/android/base/resources/xml/preferences_vendor.xml#newcode22 > ...
2 years, 3 months ago (2017-11-10 07:47:47 UTC) #2
jens
2 years, 3 months ago (2017-11-10 07:56:27 UTC) #3
On 2017/11/10 07:47:47, anton wrote:
> On 2017/11/09 21:21:48, diegocarloslima wrote:
> >
>
https://codereview.adblockplus.org/29602576/diff/29602577/mobile/android/base...
> > File mobile/android/base/resources/xml/preferences_vendor.xml (right):
> > 
> >
>
https://codereview.adblockplus.org/29602576/diff/29602577/mobile/android/base...
> > mobile/android/base/resources/xml/preferences_vendor.xml:22:
> > android:persistent="false"/>
> > Here, I'm simply reverting the changes that we made in the upstream code,
> since
> > the URL shouldn't be defined here anymore
> 
> LGTM

LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5