Issue 6023 - Connection is not closed if response code was not 200

libadblockplus-android/src/org/adblockplus/libadblockplus/android/AndroidWebRequest.java

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 110 matching lines @@
       final URL url = new URL(urlStr);
       Log.d(TAG, "Downloading from: " + url);
 
       final HttpURLConnection connection = (HttpURLConnection) url.openConnection();
       connection.setRequestMethod("GET");
       connection.setRequestProperty("Accept-Encoding",
         (compressedStream ? ENCODING_GZIP : ENCODING_IDENTITY));
       connection.connect();
 
       final ServerResponse response = new ServerResponse();
-      response.setResponseStatus(connection.getResponseCode());
+      try
+      {
+        response.setResponseStatus(connection.getResponseCode());
 
-      if (response.getResponseStatus() == 200)
-      {
-        final InputStream inputStream =
-          (compressedStream && ENCODING_GZIP.equals(connection.getContentEncoding())
-            ? new GZIPInputStream(connection.getInputStream())
-            : connection.getInputStream());
-        final BufferedReader reader = new BufferedReader(new InputStreamReader(inputStream, "UTF-8"));
-        final StringBuilder sb = new StringBuilder();
+        if (response.getResponseStatus() == 200)
+        {
+          final InputStream inputStream =
+            (compressedStream && ENCODING_GZIP.equals(connection.getContentEncoding())
+              ? new GZIPInputStream(connection.getInputStream())
+              : connection.getInputStream());
+          final BufferedReader reader = new BufferedReader(new InputStreamReader(inputStream, "UTF-8"));
+          final StringBuilder sb = new StringBuilder();
 
-        String line;
-        try
-        {
-          while ((line = reader.readLine()) != null)
-          {
-            // We're only appending non-element-hiding filters here.
-            //
-            // See:
-            //      https://issues.adblockplus.org/ticket/303
-            //
-            // Follow-up issue for removing this hack:
-            //      https://issues.adblockplus.org/ticket/1541
-            //
-            if (this.elemhideEnabled || !isListedSubscriptionUrl(url) || line.indexOf('#') == -1)
-            {
-              sb.append(line);
-              sb.append('\n');
-            }
-          }
-        }
-        finally
-        {
+          String line;
           try
           {
-            reader.close();
-          }
-          catch (IOException e)
-          {
-            // ignored
-          }
-        }
-
-        response.setStatus(NsStatus.OK);
-        response.setResponse(sb.toString());
-
-        if (connection.getHeaderFields().size() > 0)
-        {
-          List<HeaderEntry> responseHeaders = new LinkedList<HeaderEntry>();
-          for (Map.Entry<String, List<String>> eachEntry : connection.getHeaderFields().entrySet())
-          {
-            for (String eachValue : eachEntry.getValue())
+            while ((line = reader.readLine()) != null)
             {
-              if (eachEntry.getKey() != null && eachValue != null)
+              // We're only appending non-element-hiding filters here.
+              //
+              // See:
+              //      https://issues.adblockplus.org/ticket/303
+              //
+              // Follow-up issue for removing this hack:
+              //      https://issues.adblockplus.org/ticket/1541
+              //
+              if (this.elemhideEnabled || !isListedSubscriptionUrl(url) || line.indexOf('#') == -1)
               {
-                responseHeaders.add(new HeaderEntry(eachEntry.getKey().toLowerCase(), eachValue));
+                sb.append(line);
+                sb.append('\n');
               }
             }
           }
-          response.setReponseHeaders(responseHeaders);
+          finally
+          {
+            try
+            {
+              reader.close();
+            }
+            catch (IOException e)
+            {
+              // ignored
+            }
+          }
+
+          response.setStatus(NsStatus.OK);
+          response.setResponse(sb.toString());
+
+          if (connection.getHeaderFields().size() > 0)
+          {
+            List<HeaderEntry> responseHeaders = new LinkedList<HeaderEntry>();
+            for (Map.Entry<String, List<String>> eachEntry : connection.getHeaderFields().entrySet())
+            {
+              for (String eachValue : eachEntry.getValue())
+              {
+                if (eachEntry.getKey() != null && eachValue != null)
+                {
+                  responseHeaders.add(new HeaderEntry(eachEntry.getKey().toLowerCase(), eachValue));
+                }
+              }
+            }
+            response.setReponseHeaders(responseHeaders);
+          }
         }
-
+        else
+        {
+          response.setStatus(NsStatus.ERROR_FAILURE);
+        }
+      }
+      finally
+      {
         connection.disconnect();
       }
-      else
-      {
-        response.setStatus(NsStatus.ERROR_FAILURE);
-      }
       Log.d(TAG, "Downloading finished");
       return response;
     }
     catch (final Throwable t)
     {
       Log.e(TAG, "WebRequest failed", t);
       throw new AdblockPlusException("WebRequest failed", t);
     }
   }
 }