Issue 5931 - Create tests for util package

adblockplussbrowser/src/test/java/org/adblockplus/sbrowser/contentblocker/engine/UtilsTest.kt

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 12 matching lines @@
 import org.adblockplus.sbrowser.contentblocker.util.SharedPrefsUtils
 import org.adblockplus.sbrowser.contentblocker.util.SubscriptionUtils
 import org.junit.Assert.assertEquals
 import org.junit.Assert.assertNotEquals
 import org.junit.Before
 import org.junit.Test
 import org.junit.runner.RunWith
 import org.mockito.Mockito.mock
 import org.robolectric.RobolectricTestRunner
 import org.robolectric.RuntimeEnvironment
-import java.util.*

[diegocarloslima, 2017/11/13 21:10:13]

I don't really like using wildcards on imports

[jens, 2017/11/14 10:57:58]

Acknowledged.

+import java.util.Locale
 
 @RunWith(RobolectricTestRunner::class)
 class UtilsTest
 {
-
-    private var mockedDefaultSubs: DefaultSubscriptions? = null
-    private var context: Context? = null

[anton, 2017/11/14 06:04:09]

it would be better to have it marked with `lateinit` and be not nullable IMHO:
`lateinit val context: Context`

[jens, 2017/11/14 10:57:59]

Acknowledged.

[jens, 2017/11/14 11:03:54]

But lateinit can only be used on var. So I will change it to private lateinit
var context: Context.

+    private lateinit var mockedDefaultSubs: DefaultSubscriptions
+    private lateinit var context: Context
     private val EASYLIST_GERMANY_COMPLETE_URL =
             "https://easylist-downloads.adblockplus.org/easylistgermany+easylist.txt"
 
     @Before
     fun setup()
     {
         context = RuntimeEnvironment.application
         mockedDefaultSubs = mock(DefaultSubscriptions::class.java)
         RuntimeEnvironment.application.resources
-                .openRawResource(R.raw.subscriptions).use({ subscriptionsXml -> mockedDefaultSubs =

[diegocarloslima, 2017/11/13 21:10:13]

Is this parenthesis in .use( really necessary?

[jens, 2017/11/14 10:57:58]

No it's not. Good catch.

-                DefaultSubscriptions.fromStream(subscriptionsXml) })
+                .openRawResource(R.raw.subscriptions).use{ subscriptionsXml -> mockedDefaultSubs =
+                DefaultSubscriptions.fromStream(subscriptionsXml) }
     }
 
     @Test
     fun subscriptionUtilsChooseDefaultSubscriptionForEmptyList()
     {
         assertEquals(SubscriptionUtils.chooseDefaultSubscriptionUrl(
                 emptyList<DefaultSubscriptionInfo>()), Engine.EASYLIST_URL)
     }
 
     @Test
@@ skipping 93 matching lines @@
     @Test
     fun sharedPrefsUtilsPutAndGetDifferentStringSet()
     {
         val testStringSet = setOf("Hello", "World")
         SharedPrefsUtils.putStringSet(context, R.string.key_previous_version_code, testStringSet)
         val unequalStringSet = SharedPrefsUtils.getStringSet(context,
                 R.string.key_aa_info_shown, setOf("Hello", "World", "!"))
         assertNotEquals(testStringSet, unequalStringSet)
     }
 }