Issue 5931 - Create tests for util package

adblockplussbrowser/src/test/java/org/adblockplus/sbrowser/contentblocker/engine/UtilsTest.kt

Index: adblockplussbrowser/src/test/java/org/adblockplus/sbrowser/contentblocker/engine/UtilsTest.kt
===================================================================
new file mode 100644
--- /dev/null
+++ b/adblockplussbrowser/src/test/java/org/adblockplus/sbrowser/contentblocker/engine/UtilsTest.kt
@@ -0,0 +1,164 @@
+/*
+ * This file is part of Adblock Plus <https://adblockplus.org/>,
+ * Copyright (C) 2006-present eyeo GmbH
+ *
+ * Adblock Plus is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 3 as
+ * published by the Free Software Foundation.
+ *
+ * Adblock Plus is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+package org.adblockplus.sbrowser.contentblocker.engine
+
+import android.content.Context
+import android.content.res.Resources
+import org.adblockplus.adblockplussbrowser.R
+import org.adblockplus.sbrowser.contentblocker.util.SharedPrefsUtils
+import org.adblockplus.sbrowser.contentblocker.util.SubscriptionUtils
+import org.junit.Assert.assertEquals
+import org.junit.Assert.assertNotEquals
+import org.junit.Before
+import org.junit.Test
+import org.junit.runner.RunWith
+import org.mockito.Mockito.mock
+import org.robolectric.RobolectricTestRunner
+import org.robolectric.RuntimeEnvironment
+import java.util.*

[diegocarloslima, 2017/11/13 21:10:13]

I don't really like using wildcards on imports

[jens, 2017/11/14 10:57:58]

Acknowledged.

+
+@RunWith(RobolectricTestRunner::class)
+class UtilsTest
+{
+
+    private var mockedDefaultSubs: DefaultSubscriptions? = null
+    private var context: Context? = null

[anton, 2017/11/14 06:04:09]

it would be better to have it marked with `lateinit` and be not nullable IMHO:
`lateinit val context: Context`

[jens, 2017/11/14 10:57:59]

Acknowledged.

[jens, 2017/11/14 11:03:54]

But lateinit can only be used on var. So I will change it to private lateinit
var context: Context.

+    private val EASYLIST_GERMANY_COMPLETE_URL =
+            "https://easylist-downloads.adblockplus.org/easylistgermany+easylist.txt"
+
+    @Before
+    fun setup()
+    {
+        context = RuntimeEnvironment.application
+        mockedDefaultSubs = mock(DefaultSubscriptions::class.java)
+        RuntimeEnvironment.application.resources
+                .openRawResource(R.raw.subscriptions).use({ subscriptionsXml -> mockedDefaultSubs =

[diegocarloslima, 2017/11/13 21:10:13]

Is this parenthesis in .use( really necessary?

[jens, 2017/11/14 10:57:58]

No it's not. Good catch.

+                DefaultSubscriptions.fromStream(subscriptionsXml) })
+    }
+
+    @Test
+    fun subscriptionUtilsChooseDefaultSubscriptionForEmptyList()
+    {
+        assertEquals(SubscriptionUtils.chooseDefaultSubscriptionUrl(
+                emptyList<DefaultSubscriptionInfo>()), Engine.EASYLIST_URL)
+    }
+
+    @Test
+    fun subscriptionUtilsDefaultSubscriptionForChinaIsNotEasylist()
+    {
+        Resources.getSystem().configuration.setLocale(Locale.CHINA)
+        assertNotEquals(SubscriptionUtils.chooseDefaultSubscriptionUrl(
+                mockedDefaultSubs?.adsSubscriptions), Engine.EASYLIST_URL)
+    }
+
+    @Test
+    fun subscriptionUtilsChooseDefaultSubscriptionUrlForGerman()
+    {
+        Resources.getSystem().configuration.setLocale(Locale.GERMANY)
+        assertEquals(SubscriptionUtils.chooseDefaultSubscriptionUrl(
+                mockedDefaultSubs?.adsSubscriptions), EASYLIST_GERMANY_COMPLETE_URL)
+    }
+
+    @Test
+    fun subscriptionUtilsChooseDefaultSubscriptionForUnsupportedLanguage()
+    {
+        Resources.getSystem().configuration.setLocale(Locale.forLanguageTag("ab-xy"))
+        assertEquals(SubscriptionUtils.chooseDefaultSubscriptionUrl(
+                mockedDefaultSubs?.adsSubscriptions), Engine.EASYLIST_URL)
+    }
+
+    @Test
+    fun sharedPrefsUtilsPutAndGetSameBoolean()
+    {
+        val testBoolean = true
+        SharedPrefsUtils.putBoolean(context, R.string.key_aa_info_shown, testBoolean)
+        val equalBoolean = SharedPrefsUtils.getBoolean(context, R.string.key_aa_info_shown,
+                !testBoolean)
+        assertEquals(testBoolean, equalBoolean)
+    }
+
+    @Test
+    fun sharedPrefsUtilsPutAndGetDifferentBoolean()
+    {
+        val testBoolean = true
+        SharedPrefsUtils.putBoolean(context, R.string.key_aa_info_shown, testBoolean)
+        val unequalBoolean = SharedPrefsUtils.getBoolean(context, R.string.key_acceptable_ads,
+                !testBoolean)
+        assertNotEquals(testBoolean, unequalBoolean)
+    }
+
+    @Test
+    fun sharedPrefsUtilsPutAndGetSameInteger()
+    {
+        val testInteger = 5
+        SharedPrefsUtils.putInt(context, R.string.key_whitelisted_websites, testInteger)
+        val equalInteger = SharedPrefsUtils.getInt(context, R.string.key_whitelisted_websites,
+                testInteger + 1)
+        assertEquals(testInteger, equalInteger)
+    }
+
+    @Test
+    fun sharedPrefsUtilsPutAndGetDifferentInteger()
+    {
+        val testInteger = 5
+        SharedPrefsUtils.putInt(context, R.string.key_whitelisted_websites, testInteger)
+        val unequalInteger = SharedPrefsUtils.getInt(context,
+                R.string.key_application_activated, testInteger + 1)
+        assertNotEquals(testInteger, unequalInteger)
+    }
+
+    @Test
+    fun sharedPrefsUtilsPutAndGetSameString()
+    {
+        val testString = "Hello World"
+        SharedPrefsUtils.putString(context, R.string.key_automatic_updates, testString)
+        val equalString = SharedPrefsUtils.getString(context, R.string.key_automatic_updates,
+                testString + "!")
+        assertEquals(testString, equalString)
+    }
+
+    @Test
+    fun sharedPrefsUtilsPutAndGetDifferentString()
+    {
+        val testString = "Hello World"
+        SharedPrefsUtils.putString(context, R.string.key_automatic_updates, testString)
+        val unequalString = SharedPrefsUtils.getString(context,
+                R.string.key_cached_filter_path, testString + "!")
+        assertNotEquals(testString, unequalString)
+    }
+
+    @Test
+    fun sharedPrefsUtilsPutAndGetSameStringSet()
+    {
+        val testStringSet = setOf("Hello", "World")
+        SharedPrefsUtils.putStringSet(context, R.string.key_previous_version_code, testStringSet)
+        val equalStringSet = SharedPrefsUtils.getStringSet(context,
+                R.string.key_previous_version_code, setOf("Hello", "World", "!"))
+        assertEquals(testStringSet, equalStringSet)
+    }
+
+    @Test
+    fun sharedPrefsUtilsPutAndGetDifferentStringSet()
+    {
+        val testStringSet = setOf("Hello", "World")
+        SharedPrefsUtils.putStringSet(context, R.string.key_previous_version_code, testStringSet)
+        val unequalStringSet = SharedPrefsUtils.getStringSet(context,
+                R.string.key_aa_info_shown, setOf("Hello", "World", "!"))
+        assertNotEquals(testStringSet, unequalStringSet)
+    }
+}