static/scss/_utilities.scss - Issue 29603821: Noissue - Separated website-default utilities

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: static/scss/_utilities.scss

Issue 29603821: Noissue - Separated website-default utilities (Closed) Base URL: https://hg.adblockplus.org/website-defaults

Left Patch Set: Created Nov. 10, 2017, 2:04 p.m.

Right Patch Set: Addressed comments #13 Created Dec. 14, 2017, 1:36 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 // This file is part of website-defaults

2 // Copyright (C) 2016-present eyeo GmbH

3 //

4 // website-defaults is free software: you can redistribute it and/or

5 // modify it under the terms of the GNU General Public License as published by

6 // the Free Software Foundation, either version 3 of the License, or

7 // (at your option) any later version.

8 //

9 // website-defaults is distributed in the hope that it will be useful,

10 // but WITHOUT ANY WARRANTY; without even the implied warranty of

11 // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the

12 // GNU General Public License for more details.

13 //

14 // You should have received a copy of the GNU General Public License

15 // along with website-defaults. If not, see <http://www.gnu.org/licenses/>.

16

17 /*******************************************************************************

18 * Utilities
juliandoucette 2017/11/10 14:08:04 Detail: The imports below are in alphabetical orde Detail: The imports below are in alphabetical order. I'd like to avoid order dependency by importing dependencies per component. e.g. if the navbar needs .container then it should import responsive-widths instead of assuming that it's available or importing all of utilities. I think that this is the logical next step if we agree to this separation. ire 2017/11/13 08:33:37 If we import by component, wouldn't that mean we w Show quoted text On 2017/11/10 14:08:04, juliandoucette wrote: > Detail: The imports below are in alphabetical order. I'd like to avoid order > dependency by importing dependencies per component. e.g. if the navbar needs > .container then it should import responsive-widths instead of assuming that it's > available or importing all of utilities. I think that this is the logical next > step if we agree to this separation. If we import by component, wouldn't that mean we would have different components importing the same utilities and have duplication? juliandoucette 2017/11/13 12:32:59 I didn't think so at the time :( Apparently the f Show quoted text On 2017/11/13 08:33:37, ire wrote: > If we import by component, wouldn't that mean we would have different components > importing the same utilities and have duplication? I didn't think so at the time :( Apparently the fix for this is a 4.0 feature. I suspect that there is already a fix for this out there. But I'm not sure if I want to bother yet. ire 2017/11/14 07:14:50 Ack. It would be awesome to do it this way when th Show quoted text On 2017/11/13 12:32:59, juliandoucette wrote: > On 2017/11/13 08:33:37, ire wrote: > > If we import by component, wouldn't that mean we would have different > components > > importing the same utilities and have duplication? > > I didn't think so at the time :( > > Apparently the fix for this is a 4.0 feature. I suspect that there is already a > fix for this out there. But I'm not sure if I want to bother yet. Ack. It would be awesome to do it this way when the fix is ready.
19 ******************************************************************************/

20

21 @import "utilities/background-colors.scss";
ire 2017/11/13 08:33:37 NIT: I think we should not have this file and have NIT: I think we should not have this file and have these imports in main.scss (like the form imports) juliandoucette 2017/11/13 12:32:59 I just thought that - I agree. Show quoted text On 2017/11/13 08:33:37, ire wrote: > NIT: I think we should not have this file and have these imports in main.scss > (like the form imports) I just thought that - I agree.
22 @import "utilities/clearfix.scss";

23 @import "utilities/device-widths.scss";

24 @import "utilities/responsive-widths.scss";

25 @import "utilities/screen-reader-only.scss";

26 @import "utilities/text-alignment.scss";

27 @import "utilities/unstyled.scss";

LEFT	RIGHT