Noissue - Separated website-default utilities

static/scss/main.scss

Index: static/scss/main.scss
===================================================================
--- a/static/scss/main.scss
+++ b/static/scss/main.scss
@@ -13,15 +13,22 @@
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with website-defaults.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 @import "variables";
 @import "reset";
-@import "utilities";
 @import "base";
 @import "content";
 @import "grid";
 @import "forms/basic";
 @import "forms/advanced";
 @import "forms/buttons";
+@import "utilities/responsive-widths.scss";

[ire, 2017/12/07 11:44:20]

I think utilities should come earlier (after reset) because they could be
used/extended by other styles

[juliandoucette, 2017/12/07 12:33:57]

They ( are / can be ) extended ( in / by ) imports that are listed before them
AFAIK.

I will move them anyway.

[ire, 2017/12/11 15:44:03]

You didn't move them?

[juliandoucette, 2017/12/14 13:37:07]

oops. Done.

+@import "utilities/fixed-widths.scss";

[ire, 2017/12/07 11:44:20]

NIT: I think some of these categories are a bit too specific, meaning we will
end up with loads more files for each of these utilities when we add more. I
suggest having a bit more broad category names, e.g.:

- "colors" instead if background-colors
- "text" instead of text-alignment"
- "containers" for responsive-widths and fixed-widths (Not so sure about this
one, maybe "widths")

(Taking inspiration from Bootstrap's naming)

[juliandoucette, 2017/12/07 12:33:57]

Agreed.

[juliandoucette, 2017/12/08 16:11:06]

Done.

+@import "utilities/floats.scss";
+@import "utilities/clearfix.scss";
+@import "utilities/background-colors.scss";
+@import "utilities/text-alignment.scss";
+@import "utilities/unstyled.scss";
+@import "utilities/screen-reader.scss";