Issue 5965 - Handle edge case when searching for options page tab

lib/options.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 46 matching lines @@
       callback();
       return;
     }
     let removeListener;
     let updateListener = (tabId, changeInfo, tab) =>
     {
       if (potentialOptionTabIds.has(tabId) &&
           changeInfo.status == "complete")
       {
         potentialOptionTabIds.delete(tabId);
-        let urlMatches = tab.url == fullOptionsUrl;

[Wladimir Palant, 2017/11/23 11:37:12]

Nit: Variable names are supposed to be nouns, not verbs. urlMatch maybe?

[kzar, 2017/11/23 11:51:08]

Done. (It's quite nice in Clojure you can use symbols like "?" so you could have
a variable name url-matches?.)

-        if (urlMatches || potentialOptionTabIds.size == 0)
+        let urlMatch = tab.url == fullOptionsUrl;
+        if (urlMatch || potentialOptionTabIds.size == 0)
         {
           browser.tabs.onUpdated.removeListener(updateListener);
           browser.tabs.onRemoved.removeListener(removeListener);
-          callback(urlMatches ? tab : undefined);
+          callback(urlMatch ? tab : undefined);
         }
       }
     };
     browser.tabs.onUpdated.addListener(updateListener);
     removeListener = removedTabId =>
     {
       potentialOptionTabIds.delete(removedTabId);
       if (potentialOptionTabIds.size == 0)
       {
         browser.tabs.onUpdated.removeListener(updateListener);
@@ skipping 106 matching lines @@
         args: [
           {
             host: getDecodedHostname(currentPage.url).replace(/^www\./, ""),
             whitelisted: !!checkWhitelisted(currentPage)
           }
         ]
       });
     });
   });
 });