Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(290)

Issue 29607555: Issue 6030 - Ensure RTCPeerConnection exists before wrapping it (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 10 months ago by kzar
Modified:
1 year, 10 months ago
CC:
Sebastian Noack
Visibility:
Public.

Description

Issue 6030 - Ensure RTCPeerConnection exists before wrapping it

Patch Set 1 #

Total comments: 3

Patch Set 2 : Wrap WebRTC wrapping code in the if block #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -130 lines) Patch
M inject.preload.js View 1 1 chunk +137 lines, -130 lines 1 comment Download

Messages

Total messages: 6
kzar
Patch Set 1
1 year, 10 months ago (2017-11-14 10:36:29 UTC) #1
Manish Jethani
https://codereview.adblockplus.org/29607555/diff/29607556/inject.preload.js File inject.preload.js (right): https://codereview.adblockplus.org/29607555/diff/29607556/inject.preload.js#newcode229 inject.preload.js:229: // Firefox has the option (media.peerconnection.enabled) to disable WebRTC ...
1 year, 10 months ago (2017-11-14 10:57:56 UTC) #2
Wladimir Palant
https://codereview.adblockplus.org/29607555/diff/29607556/inject.preload.js File inject.preload.js (right): https://codereview.adblockplus.org/29607555/diff/29607556/inject.preload.js#newcode229 inject.preload.js:229: // Firefox has the option (media.peerconnection.enabled) to disable WebRTC ...
1 year, 10 months ago (2017-11-14 11:12:50 UTC) #3
kzar
Patch Set 2 : Wrap WebRTC wrapping code in the if block https://codereview.adblockplus.org/29607555/diff/29607556/inject.preload.js File inject.preload.js ...
1 year, 10 months ago (2017-11-14 11:36:36 UTC) #4
Wladimir Palant
LGTM assuming that all that changed is converting regular functions to arrow functions.
1 year, 10 months ago (2017-11-14 12:17:53 UTC) #5
Manish Jethani
1 year, 10 months ago (2017-11-14 13:14:23 UTC) #6
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5