 Issue 29607560:
  Issue 6003 - Better handling of no-content-for-platform-message on help.eyeo.com  (Closed) 
  Base URL: https://hg.adblockplus.org/help.eyeo.com
    
  
    Issue 29607560:
  Issue 6003 - Better handling of no-content-for-platform-message on help.eyeo.com  (Closed) 
  Base URL: https://hg.adblockplus.org/help.eyeo.com| Left: | ||
| Right: | 
| OLD | NEW | 
|---|---|
| 1 // This file is part of help.eyeo.com. | 1 // This file is part of help.eyeo.com. | 
| 2 // Copyright (C) 2017 Eyeo GmbH | 2 // Copyright (C) 2017 Eyeo GmbH | 
| 3 // | 3 // | 
| 4 // help.eyeo.com is free software: you can redistribute it and/or modify | 4 // help.eyeo.com is free software: you can redistribute it and/or modify | 
| 5 // it under the terms of the GNU General Public License as published by | 5 // it under the terms of the GNU General Public License as published by | 
| 6 // the Free Software Foundation, either version 3 of the License, or | 6 // the Free Software Foundation, either version 3 of the License, or | 
| 7 // (at your option) any later version. | 7 // (at your option) any later version. | 
| 8 // | 8 // | 
| 9 // help.eyeo.com is distributed in the hope that it will be useful, | 9 // help.eyeo.com is distributed in the hope that it will be useful, | 
| 10 // but WITHOUT ANY WARRANTY; without even the implied warranty of | 10 // but WITHOUT ANY WARRANTY; without even the implied warranty of | 
| (...skipping 11 matching lines...) Expand all Loading... | |
| 22 { | 22 { | 
| 23 padding: $md; | 23 padding: $md; | 
| 24 | 24 | 
| 25 @media (min-width: $phablet-breakpoint) | 25 @media (min-width: $phablet-breakpoint) | 
| 26 { | 26 { | 
| 27 padding: $lg; | 27 padding: $lg; | 
| 28 } | 28 } | 
| 29 } | 29 } | 
| 30 | 30 | 
| 31 .article-heading, | 31 .article-heading, | 
| 32 .article-browser-selector | 32 .article-browser-selector, | 
| 33 #no-content-for-platform-message | |
| 
juliandoucette
2017/11/15 13:27:44
NIT: Why should this article content have a border
 
ire
2017/11/15 16:57:30
I guess I don't really see it as article content.
 
juliandoucette
2017/11/15 18:03:33
Does it ever not replace the article content as th
 
ire
2017/11/27 18:26:45
Yes. There are cases where there is "general" cont
 | |
| 33 { | 34 { | 
| 34 padding-bottom: $md; | 35 padding-bottom: $md; | 
| 35 margin-bottom: $md; | 36 margin-bottom: $md; | 
| 36 border-bottom: 1px dotted $gray; | 37 border-bottom: 1px dotted $gray; | 
| 37 } | 38 } | 
| 38 | 39 | 
| 39 .article-heading .has-pre-icon | 40 .article-heading .has-pre-icon | 
| 40 { | 41 { | 
| 41 @media (max-width: $phablet-breakpoint - 1) | 42 @media (max-width: $phablet-breakpoint - 1) | 
| 42 { | 43 { | 
| (...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 80 display: none; | 81 display: none; | 
| 81 } | 82 } | 
| 82 | 83 | 
| 83 @each $browser in $supported-browsers | 84 @each $browser in $supported-browsers | 
| 84 { | 85 { | 
| 85 .js .ua-#{$browser} .platform-#{$browser} | 86 .js .ua-#{$browser} .platform-#{$browser} | 
| 86 { | 87 { | 
| 87 display: block; | 88 display: block; | 
| 88 } | 89 } | 
| 89 } | 90 } | 
| OLD | NEW |