Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: templates/article.tmpl

Issue 29607560: Issue 6003 - Better handling of no-content-for-platform-message on help.eyeo.com (Closed) Base URL: https://hg.adblockplus.org/help.eyeo.com
Left Patch Set: Rebase Created Nov. 14, 2017, 3:27 p.m.
Right Patch Set: Addressed NITs Created Dec. 12, 2017, 10:20 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « static/src/scss/content/_typography.scss ('k') | no next file » | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 {% extends "templates/minimal" %} 1 {% extends "templates/minimal" %}
2 2
3 {% set product = products[product_id] %} 3 {% set product = products[product_id] %}
4 4
5 {% block body %} 5 {% block body %}
6 <nav aria-label="{{ "Breadcrumb" | translate("breadcrumb-label", "Label") }}" cl ass="breadcrumb"> 6 <nav aria-label="{{ "Breadcrumb" | translate("breadcrumb-label", "Label") }}" cl ass="breadcrumb">
7 <ol class="container large-desktop-width clearfix" itemscope itemtype="http:// schema.org/BreadcrumbList"> 7 <ol class="container large-desktop-width clearfix" itemscope itemtype="http:// schema.org/BreadcrumbList">
8 <li itemprop="itemListElement" itemscope itemtype="http://schema.org/ListIte m"> 8 <li itemprop="itemListElement" itemscope itemtype="http://schema.org/ListIte m">
9 <a class="has-pre-icon" itemscope itemtype="http://schema.org/Thing" itemp rop="item" href="{{ product.slug }}"> 9 <a class="has-pre-icon" itemscope itemtype="http://schema.org/Thing" itemp rop="item" href="{{ product.slug }}">
10 <span class="pre-icon" style="{{ get_inline_bg('logo-'+product_id) }}">< /span> 10 <span class="pre-icon" style="{{ get_inline_bg('logo-'+product_id) }}">< /span>
(...skipping 19 matching lines...) Expand all
30 <span class="pre-icon" style="{{ get_inline_bg('logo-'+product_id) } }"></span> 30 <span class="pre-icon" style="{{ get_inline_bg('logo-'+product_id) } }"></span>
31 {{ title | translate( get_page_name(page) + "-title", "Article title ") }} 31 {{ title | translate( get_page_name(page) + "-title", "Article title ") }}
32 </h1> 32 </h1>
33 </header> 33 </header>
34 34
35 {% if hide_browser_selector is not defined %} 35 {% if hide_browser_selector is not defined %}
36 <div class="article-browser-selector"> 36 <div class="article-browser-selector">
37 <? include browser-select ?> 37 <? include browser-select ?>
38 </div> 38 </div>
39 39
40 <div id="no-content-for-platform-message" class="content" aria-hidden="t rue" hidden> 40 <div id="no-content-for-platform-notice" class="content" hidden>
juliandoucette 2017/11/15 13:27:45 I think that aria-hidden and hidden is redundant.
ire 2017/11/15 16:57:30 You're right. I wasn't sure about this myself. Tha
41 <p>{{ "Unfortunately, there is no content specific to your current bro wser. Please choose a different browser from the list below:" | translate("no-co ntent-for-platform-message", "paragraph") }}</p> 41 <p>{{ "Oops! There is no article for the subject and browser that you have selected. Please find a list of browsers that this article is available for below." | translate("no-content-for-platform-notice", "notice") }}</p>
juliandoucette 2017/11/15 13:27:45 NIT: This message doesn't make sense when you sele
ire 2017/11/15 16:57:30 Why doesn't it make sense? And do you have a sugge
juliandoucette 2017/11/15 18:03:33 "Your current browser" means "the browser that you
ire 2017/11/27 18:26:45 Ack. I understand.
42 <ul> 42 <ul>
43 {% for browser in browsers %} 43 {% for browser in browsers %}
44 <li class="{{ browser.id }}"> 44 <li data-value="{{ browser.id }}">
45 <button type="button" class="btn-link"> 45 <button type="button" class="button-link">
46 {{ browser.name | translate(browser.id + "-name") }} 46 {{ browser.name | translate(browser.id + "-name") }}
47 </button> 47 </button>
48 </li> 48 </li>
49 {% endfor %} 49 {% endfor %}
50 </ul> 50 </ul>
51 </div> 51 </div>
52 {% endif %} 52 {% endif %}
53 53
54 <div class="article-body content"> 54 <div class="article-body content">
55 {{ body | safe }} 55 {{ body | safe }}
56 </div> 56 </div>
57 </article> 57 </article>
58 </div> 58 </div>
59 <aside class="section column one-third"> 59 <aside class="section column one-third">
60 <? include product-topics-accordion ?> 60 <? include product-topics-accordion ?>
61 </aside> 61 </aside>
62 </div> 62 </div>
63 </main> 63 </main>
64 {% endblock %} 64 {% endblock %}
65 65
66 {% block footer %} 66 {% block footer %}
67 <? include contact ?> 67 <? include contact ?>
68 {% endblock %} 68 {% endblock %}
69 69
70 {% block scripts %} 70 {% block scripts %}
71 <script src="/js/vendor/bowser.js"></script> 71 <script src="/dist/js/vendor/bowser.min.js"></script>
72 {% endblock %} 72 {% endblock %}
LEFTRIGHT

Powered by Google App Engine
This is Rietveld