 Issue 29607560:
  Issue 6003 - Better handling of no-content-for-platform-message on help.eyeo.com  (Closed) 
  Base URL: https://hg.adblockplus.org/help.eyeo.com
    
  
    Issue 29607560:
  Issue 6003 - Better handling of no-content-for-platform-message on help.eyeo.com  (Closed) 
  Base URL: https://hg.adblockplus.org/help.eyeo.com| Left: | ||
| Right: | 
| LEFT | RIGHT | 
|---|---|
| 1 {% extends "templates/minimal" %} | 1 {% extends "templates/minimal" %} | 
| 2 | 2 | 
| 3 {% set product = products[product_id] %} | 3 {% set product = products[product_id] %} | 
| 4 | 4 | 
| 5 {% block body %} | 5 {% block body %} | 
| 6 <nav aria-label="{{ "Breadcrumb" | translate("breadcrumb-label", "Label") }}" cl ass="breadcrumb"> | 6 <nav aria-label="{{ "Breadcrumb" | translate("breadcrumb-label", "Label") }}" cl ass="breadcrumb"> | 
| 7 <ol class="container large-desktop-width clearfix" itemscope itemtype="http:// schema.org/BreadcrumbList"> | 7 <ol class="container large-desktop-width clearfix" itemscope itemtype="http:// schema.org/BreadcrumbList"> | 
| 8 <li itemprop="itemListElement" itemscope itemtype="http://schema.org/ListIte m"> | 8 <li itemprop="itemListElement" itemscope itemtype="http://schema.org/ListIte m"> | 
| 9 <a class="has-pre-icon" itemscope itemtype="http://schema.org/Thing" itemp rop="item" href="{{ product.slug }}"> | 9 <a class="has-pre-icon" itemscope itemtype="http://schema.org/Thing" itemp rop="item" href="{{ product.slug }}"> | 
| 10 <span class="pre-icon" style="{{ get_inline_bg('logo-'+product_id) }}">< /span> | 10 <span class="pre-icon" style="{{ get_inline_bg('logo-'+product_id) }}">< /span> | 
| (...skipping 19 matching lines...) Expand all Loading... | |
| 30 <span class="pre-icon" style="{{ get_inline_bg('logo-'+product_id) } }"></span> | 30 <span class="pre-icon" style="{{ get_inline_bg('logo-'+product_id) } }"></span> | 
| 31 {{ title | translate( get_page_name(page) + "-title", "Article title ") }} | 31 {{ title | translate( get_page_name(page) + "-title", "Article title ") }} | 
| 32 </h1> | 32 </h1> | 
| 33 </header> | 33 </header> | 
| 34 | 34 | 
| 35 {% if hide_browser_selector is not defined %} | 35 {% if hide_browser_selector is not defined %} | 
| 36 <div class="article-browser-selector"> | 36 <div class="article-browser-selector"> | 
| 37 <? include browser-select ?> | 37 <? include browser-select ?> | 
| 38 </div> | 38 </div> | 
| 39 | 39 | 
| 40 <div id="no-content-for-platform-message" class="content" hidden> | 40 <div id="no-content-for-platform-notice" class="content" hidden> | 
| 41 <p>{{ "Oops! There is no article for the subject and browser that you have selected. Please find a list of browsers that this article is available for below." | translate("no-content-for-platform-message", "paragraph") }}</p> | 41 <p>{{ "Oops! There is no article for the subject and browser that you have selected. Please find a list of browsers that this article is available for below." | translate("no-content-for-platform-notice", "notice") }}</p> | 
| 
juliandoucette
2017/12/11 15:15:28
TOL: The paragraph description is arguably the ~de
 
juliandoucette
2017/12/11 15:15:29
NIT/TOL: This is arguably more of a "notice" than
 
ire
2017/12/12 10:21:14
Ack. I think "notice" works.
 
ire
2017/12/12 10:21:14
Done.
 | |
| 42 <ul> | 42 <ul> | 
| 43 {% for browser in browsers %} | 43 {% for browser in browsers %} | 
| 44 <li data-value="{{ browser.id }}"> | 44 <li data-value="{{ browser.id }}"> | 
| 45 <button type="button" class="button-link"> | 45 <button type="button" class="button-link"> | 
| 46 {{ browser.name | translate(browser.id + "-name") }} | 46 {{ browser.name | translate(browser.id + "-name") }} | 
| 47 </button> | 47 </button> | 
| 48 </li> | 48 </li> | 
| 49 {% endfor %} | 49 {% endfor %} | 
| 50 </ul> | 50 </ul> | 
| 51 </div> | 51 </div> | 
| 52 {% endif %} | 52 {% endif %} | 
| 53 | 53 | 
| 54 <div class="article-body content"> | 54 <div class="article-body content"> | 
| 55 {{ body | safe }} | 55 {{ body | safe }} | 
| 56 </div> | 56 </div> | 
| 57 </article> | 57 </article> | 
| 58 </div> | 58 </div> | 
| 59 <aside class="section column one-third"> | 59 <aside class="section column one-third"> | 
| 60 <? include product-topics-accordion ?> | 60 <? include product-topics-accordion ?> | 
| 61 </aside> | 61 </aside> | 
| 62 </div> | 62 </div> | 
| 63 </main> | 63 </main> | 
| 64 {% endblock %} | 64 {% endblock %} | 
| 65 | 65 | 
| 66 {% block footer %} | 66 {% block footer %} | 
| 67 <? include contact ?> | 67 <? include contact ?> | 
| 68 {% endblock %} | 68 {% endblock %} | 
| 69 | 69 | 
| 70 {% block scripts %} | 70 {% block scripts %} | 
| 71 <script src="/js/vendor/bowser.js"></script> | 71 <script src="/dist/js/vendor/bowser.min.js"></script> | 
| 72 {% endblock %} | 72 {% endblock %} | 
| LEFT | RIGHT |