Issue 6003 - Better handling of no-content-for-platform-message on help.eyeo.com

static/src/js/main.js

 /*!
  * This file is part of help.eyeo.com.
  * Copyright (C) 2017-present eyeo GmbH
  *
  * help.eyeo.com is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
  * the Free Software Foundation, either version 3 of the License, or
  * (at your option) any later version.
  *
  * help.eyeo.com is distributed in the hope that it will be useful,
@@ skipping 234 matching lines @@
     }
 
     /**************************************************************************
      * BrowserSelect
      **************************************************************************/
 
     function BrowserSelect(select)
     {
       this.select = select;
       CustomSelect.apply(this, [this.select]);
-      this.noContentMessage = document.getElementById("no-content-for-platform-message");
+      this.noContentMessage = document.getElementById("no-content-for-platform-notice");
       
       this.BROWSER_STORAGE_KEY = "BROWSER";
       this.BROWSER_AUTODETECTED_STORAGE_KEY = "BROWSER_AUTODETECTED";
       this.SUPPORTED_BROWSERS = ["chrome", "opera", "samsungBrowser", 
                                  "yandexbrowser", "maxthon", "msie", 
                                  "msedge", "firefox", "ios", "safari"];
       this.DEFAULT_BROWSER = "chrome";
       
       this.setCurrentArticleSupportedBrowsers();
       
@@ skipping 14 matching lines @@
     BrowserSelect.prototype = Object.create(CustomSelect.prototype);
     BrowserSelect.prototype.constructor = BrowserSelect;
 
     BrowserSelect.prototype.setCurrentArticleSupportedBrowsers = function()
     {
       for (var i = 0; i < this.SUPPORTED_BROWSERS.length; i++)
       {
         var supportedBrowser = this.SUPPORTED_BROWSERS[i];
         if (!document.querySelector(".platform-"+supportedBrowser))
         {
-          this.noContentMessage.querySelector("[data-value='" + supportedBrowser + "']")
+          this.noContentMessage
+              .querySelector("[data-value='" + supportedBrowser + "']")
               .setAttribute("hidden", "true");
         }
       }
     };
 
     BrowserSelect.prototype.detectBrowser = function()
     {
       for (var i = 0; i < this.SUPPORTED_BROWSERS.length; i++)
       {
         var supportedBrowser = this.SUPPORTED_BROWSERS[i];
@@ skipping 68 matching lines @@
           .setAttribute("aria-checked", "false");
 
       this.selectOption(option.getAttribute("data-value"));
 
       this.close();
     };
 
     BrowserSelect.prototype._onClickNoContentMessage = function(event)
     {
       if (event.target.tagName != "BUTTON") return;
-
-      var browser = event.target.parentElement.getAttribute("data-value");
-      this.selectOption(browser);
+      this.selectOption(event.target.parentElement.getAttribute("data-value"));
     };
 
     var browserSelect = document.getElementById("browser-select");
     if (browserSelect)
     {
       new BrowserSelect(browserSelect);
     }
 
   }, false);
 }());