Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: templates/article.tmpl

Issue 29607560: Issue 6003 - Better handling of no-content-for-platform-message on help.eyeo.com (Closed) Base URL: https://hg.adblockplus.org/help.eyeo.com
Patch Set: Rebase Created Nov. 14, 2017, 3:27 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: templates/article.tmpl
===================================================================
--- a/templates/article.tmpl
+++ b/templates/article.tmpl
@@ -31,32 +31,41 @@
{{ title | translate( get_page_name(page) + "-title", "Article title") }}
</h1>
</header>
{% if hide_browser_selector is not defined %}
<div class="article-browser-selector">
<? include browser-select ?>
</div>
+
+ <div id="no-content-for-platform-message" class="content" aria-hidden="true" hidden>
juliandoucette 2017/11/15 13:27:45 I think that aria-hidden and hidden is redundant.
ire 2017/11/15 16:57:30 You're right. I wasn't sure about this myself. Tha
+ <p>{{ "Unfortunately, there is no content specific to your current browser. Please choose a different browser from the list below:" | translate("no-content-for-platform-message", "paragraph") }}</p>
juliandoucette 2017/11/15 13:27:45 NIT: This message doesn't make sense when you sele
ire 2017/11/15 16:57:30 Why doesn't it make sense? And do you have a sugge
juliandoucette 2017/11/15 18:03:33 "Your current browser" means "the browser that you
ire 2017/11/27 18:26:45 Ack. I understand.
+ <ul>
+ {% for browser in browsers %}
+ <li class="{{ browser.id }}">
+ <button type="button" class="btn-link">
+ {{ browser.name | translate(browser.id + "-name") }}
+ </button>
+ </li>
+ {% endfor %}
+ </ul>
+ </div>
{% endif %}
<div class="article-body content">
{{ body | safe }}
</div>
</article>
</div>
<aside class="section column one-third">
<? include product-topics-accordion ?>
</aside>
</div>
</main>
-
-<script id="no-content-for-platform-message" type="text/template">
- <p>{{ "Unfortunately, there is no content specific for your current browser. Please use the dropdown menu above to choose a different browser." | translate("no-content-for-platform-message", "paragraph") }}</p>
-</script>
{% endblock %}
{% block footer %}
<? include contact ?>
{% endblock %}
{% block scripts %}
<script src="/js/vendor/bowser.js"></script>
« static/scss/content/_typography.scss ('K') | « static/scss/content/_typography.scss ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld